- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1
 
Optimize Docker build context to fix slow compose up times in Copilot sessions #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 4 commits
      Commits
    
    
            Show all changes
          
          
            8 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      9686100
              
                Initial plan
              
              
                Copilot f30d6f5
              
                Optimize Docker build context to reduce transfer time from 425MB to ~…
              
              
                Copilot e7063cf
              
                Complete Docker performance optimization with documentation
              
              
                Copilot e775149
              
                Address PR feedback: rename dockerfile, add EOF newline, exclude docs…
              
              
                Copilot a462c82
              
                Remove unnecessary Eleventy config files from test container
              
              
                Copilot 65a94f6
              
                Merge branch 'master' into copilot/fix-253
              
              
                dannystaple 37575d1
              
                Merge branch 'master' into copilot/fix-253
              
              
                dannystaple 1b967c9
              
                Remove redundant .dockerignore.dev and DOCKER_OPTIMIZATION.md files
              
              
                Copilot File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
                              
      
                  dannystaple marked this conversation as resolved.
               
              
                Outdated
          
            Show resolved
            Hide resolved
         | 
            
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # Minimal .dockerignore for development Dockerfile | ||
| # Only package.json and package-lock.json are needed for npm ci | ||
| # All other content is volume-mounted at runtime | ||
| 
     | 
||
| # Exclude everything by default | ||
| * | ||
| 
     | 
||
| # But include the package files needed for npm install | ||
| !package.json | ||
| !package-lock.json | ||
| 
     | 
||
| # Exclude git and other version control | ||
| .git | ||
| .gitignore | ||
| .gitattributes | ||
| 
     | 
||
| # Exclude Docker files | ||
| Dockerfile* | ||
| docker-compose*.yml | ||
| .dockerignore* | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| 
          
            
          
           | 
    @@ -4,3 +4,4 @@ | |
| ./tests | ||
| 
     | 
||
| Dockerfile | ||
| DOCKER_OPTIMIZATION.md | ||
                              
      
                  dannystaple marked this conversation as resolved.
               
              
                Outdated
          
            Show resolved
            Hide resolved
                
      
                  dannystaple marked this conversation as resolved.
               
              
                Outdated
          
            Show resolved
            Hide resolved
         | 
            
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| # Docker Performance Optimization | ||
| 
     | 
||
| This repository uses Docker Compose for development, but was experiencing slow build times due to large build context transfers (425MB) when used in GitHub Copilot sessions. | ||
| 
     | 
||
| ## Problem | ||
| The original setup transferred the entire repository (425MB including galleries/, content/, _image_sources/) to Docker during build, even though: | ||
| - Development services use volume mounts (`.:/app/src`) | ||
| - Only npm dependencies need to be installed in the container | ||
| - Source code is mounted at runtime, not during build | ||
| 
     | 
||
| ## Solution | ||
| Created optimized Docker setup: | ||
| 
     | 
||
| ### Files Added | ||
| - `dev.Dockerfile` - Minimal dockerfile that only installs npm dependencies | ||
| - Updated `.dockerignore` - Aggressive exclusion of large directories | ||
| 
     | 
||
| ### Changes Made | ||
| - `docker-compose.yml` - Updated serve, dist, build, and shell services to use `dev.Dockerfile` | ||
| - Original `Dockerfile` - Kept for production services that need full content (httpd_serve, staging, etc.) | ||
| 
     | 
||
| ### Performance Improvement | ||
| - **Build context:** 425MB → 72 bytes (99.98% reduction, ~6000x smaller) | ||
| - **npm ci optimization:** Added `--prefer-offline --no-audit --progress=false` flags | ||
| 
     | 
||
| ## Architecture | ||
| 
     | 
||
| ### Development Services (use dev.Dockerfile) | ||
| - `serve` - Eleventy development server | ||
| - `dist` - Webpack asset bundling | ||
| - `build` - Site generation | ||
| - `shell` - Interactive debugging | ||
| 
     | 
||
| These services: | ||
| 1. Build minimal container with just npm dependencies | ||
| 2. Mount entire source code via volume at runtime | ||
| 3. No need to copy large content directories during build | ||
| 
     | 
||
| ### Production Services (use full Dockerfile) | ||
| - `httpd_serve` - Apache web server | ||
| - `staging` - Staging deployment | ||
| - `test` - BDD testing | ||
| 
     | 
||
| These services need full content copied during build since they don't use development volume mounts. | ||
| 
     | 
||
| ## Usage | ||
| Development workflows remain the same: | ||
| ```bash | ||
| docker compose up # Start development server | ||
| docker compose run dist # Build webpack assets | ||
| docker compose run build # Build static site | ||
| ``` | ||
| 
     | 
||
| The build context transfer is now nearly instantaneous instead of transferring hundreds of megabytes. | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Minimal development Dockerfile | ||
| # Only installs npm dependencies since content is volume-mounted | ||
| FROM node:24-bullseye AS base | ||
| 
     | 
||
| # Create app directory | ||
| WORKDIR /app/src | ||
| 
     | 
||
| # Copy package files and install dependencies | ||
| COPY package.json package-lock.json ./ | ||
| 
     | 
||
| # Optimize npm ci for better performance in CI environments | ||
| RUN npm ci --prefer-offline --no-audit --progress=false | ||
| 
     | 
||
| # Development debug build | ||
| FROM base AS debug | ||
| 
     | 
||
| RUN apt-get update && apt-get install -y \ | ||
| less \ | ||
| iputils-ping \ | ||
| dnsutils | ||
| 
     | 
||
| # Source code will be volume-mounted at runtime | ||
| 
     | 
||
| # Default stage - just npm dependencies installed | ||
| FROM base | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.