Convert to typescript (prepare to upgrade all dependencies) #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thdk
changed the title
thdk
force-pushed
the
chore/convert-to-typescript
branch
from
6718ad5 to
75512da
Compare
thdk
force-pushed
the
chore/convert-to-typescript
branch
from
75512da to
f057330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
We've noticed the library is a bit outdated and we would like to upgrade the dependencies.
Would you be up for using typescript and jest (instead of tap)?
Using typescript gives us more comfort for doing the upgrades as the types from the dependencies might already indicate where we should pay extra attention.
This PR should not contain any code changes or dependency upgrades yet. It's just adding the minimum type info. Add tooling for building and testing typescript files. And run prettier.
I've also included a github action to run CI.
Feel free to let me know in which changes you would be interested so I can leave the other changes out.