Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain rake version to <11.0 on Ubuntu #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maltewi
Copy link

@maltewi maltewi commented Feb 13, 2019

Building orogen led to this error on my Ubuntu16.04:

2019-02-13 10:56:17 +0100: running
    /usr/bin/ruby2.3 -S rake default
in directory /media/wirkus/Data/development/q-rock/tools/orogen
rake aborted!
NoMethodError: undefined method `last_comment' for #<Rake::Application:0x00000001c953a0>
/media/wirkus/Data/development/q-rock/tools/utilrb/lib/utilrb/doc/rake.rb:40:in `new'
/media/wirkus/Data/development/q-rock/tools/utilrb/lib/utilrb/doc/rake.rb:40:in `doc'
/media/wirkus/Data/development/q-rock/tools/orogen/Rakefile:71:in `<top (required)>'

The system got rake version rake, version 12.3.2 installed as osdep.

Stackoverflow att https://stackoverflow.com/questions/35893584/nomethoderror-undefined-method-last-comment-after-upgrading-to-rake-11 says that since Rake 11 does not provide the last_comment function anymore.

This merge request as rather a hot fix, but not as real solution, since the root of the problem is the usage of old API function (don't know where this is).

@doudou
Copy link
Contributor

doudou commented Feb 13, 2019

What you have done is breaking for any ubuntu > 16.04. Should have had a default entry.

In any case, I'd rather fix the problem. Utilrb line 40 creates YARD's rake task. Could you check what version(s) of rake and yard you have installed ?

Worst case, I'll rewrite orogen's Rakefile to get rid of this unnecessary functionality.

@doudou
Copy link
Contributor

doudou commented Feb 13, 2019

What's weird is that I've been running on Rake 12.x for a long time now. Have you pinned some package versions in Rock ?

@maltewi
Copy link
Author

maltewi commented Feb 13, 2019

  • rake: version 12.3.2 before the patch, 10.5.0 after the patch
  • yard: 0.9.18

Have you pinned some package versions in Rock ?

You mean e.g. via overrides? No.

@doudou
Copy link
Contributor

doudou commented Feb 13, 2019

Installing Rock on a vanilla 16.04 VM does not trigger the problem, unfortunately.

Given the backtrace and the error, it seems that a YARD version before 0.9.0 got loaded. Do you have the yard debian package installed, maybe ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants