Skip to content

Conversation

@shaunnkhan
Copy link
Contributor

Related Issue or Design Document

Add documentation around stateless JWT access token OEL feature

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks pretty good already although I do get very strong written by AI vibes 😁

it probably would fit here into the sidebar https://www.ory.com/docs/guides/token-management

left some style comments + also added upstream label since I assume this is for an upcoming feature

@vinckr vinckr added the upstream Issue is caused by an upstream dependency. label Nov 26, 2025
@vinckr vinckr requested a review from unatasha8 November 26, 2025 19:06
@shaunnkhan
Copy link
Contributor Author

thanks, looks pretty good already although I do get very strong written by AI vibes 😁

Yeah, and I had already trimmed some of the fat. 😁 I cleaned it up a bit more.

it probably would fit here into the sidebar https://www.ory.com/docs/guides/token-management

This feature is currently only meant for OEL, so is that sidebar location still applicable? Also, how can I add this to the sidebar?

left some style comments + also added upstream label since I assume this is for an upcoming feature

Thank you!

@vinckr
Copy link
Member

vinckr commented Nov 26, 2025

This feature is currently only meant for OEL, so is that sidebar location still applicable? Also, how can I add this to the sidebar?

You're right, we have a separate section for OEL only.
in that case you want to add it here - you'll need to add the document id for it to appear in the sidebar.

Copy link
Contributor

@unatasha8 unatasha8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions.

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🐝
lgtm

let's wait until the feature is released before merging though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upstream Issue is caused by an upstream dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants