chore(docs): update of OEL changelog#2517
Merged
Merged
Conversation
📝 WalkthroughWalkthroughAdd v26.2.5 changelog entries across OEL projects documenting: fixes for shared mutable error state, Keto expand endpoint default node cap (4,000, configurable), Kratos OIDC registration return_to behavior, phone number E.164 normalization, and identity enum dropdown rendering. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (1)
docs/self-hosted/oel/keto/changelog/v26.2.5.md (1)
8-35: Consider reducing duplicated shared-error text across OEL changelogsThis section is repeated nearly verbatim across multiple product changelogs; consider a shared include/snippet to reduce drift in future edits.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/self-hosted/oel/keto/changelog/v26.2.5.md` around lines 8 - 35, The repeated "Fix shared mutable state in error handling" section (describing issues with package-level errors like herodot.ErrNotFound and how the new API creates fresh error instances) should be extracted into a shared include/snippet and referenced from each OEL changelog to avoid duplication; create a single canonical snippet containing the explanatory text about shared mutable error state, examples of impacted values (cookies, UUIDs, OAuth2 hints, OIDC URLs, schema fetches, JWT claims), and the note about no persistent write, then replace the repeated blocks in each changelog with a short pointer/include to that snippet.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/self-hosted/oel/keto/changelog/v26.2.5.md`:
- Line 12: Update the sentence fragment "an error — reason text, details, etc,
modified the global" to use the standard abbreviation punctuation by changing
"etc" to "etc." so it reads "...details, etc., modified the global"; locate the
exact phrase in the changelog entry for v26.2.5 (the line containing "reason
text, details, etc") and add the missing period after "etc" to match American
English style.
In `@docs/self-hosted/oel/kratos/changelog/v26.2.5.md`:
- Line 7: Update the sentence fragment in the changelog that reads "etc" to
include a trailing period ("etc.") so that the phrase "an error — reason text,
details, etc" becomes "an error — reason text, details, etc."; locate the
occurrence of the word "etc" in the diff line shown and add the period to the
markdown content.
In `@docs/self-hosted/oel/oathkeeper/changelog/v26.2.5.md`:
- Line 7: In the sentence fragment "an error — reason text, details, etc,
modified the global." (the line containing "reason text, details, etc"), replace
the bare "etc" with "etc." so it reads "reason text, details, etc." and preserve
the surrounding punctuation/spacing exactly as before.
In `@docs/self-hosted/oel/oauth2/changelog/v26.2.5.md`:
- Line 7: The phrase "details, etc" in the changelog entry should end with a
period; locate the sentence containing "details, etc" (the line reading "an
error — reason text, details, etc, modified the global. The next request to
reach an error path using the same error inherited") and change "etc" to "etc."
so the sentence reads "details, etc." preserving the rest of the sentence
punctuation and spacing.
In `@docs/self-hosted/oel/polis/changelog/v26.2.5.md`:
- Line 1: Replace the plural word "versions" in the sentence "No changelog
entries found for polis/oel in versions v26.2.5" with the singular "version" so
it reads "No changelog entries found for polis/oel in version v26.2.5"; update
that string in the changelog file to fix the singular/plural mismatch.
---
Nitpick comments:
In `@docs/self-hosted/oel/keto/changelog/v26.2.5.md`:
- Around line 8-35: The repeated "Fix shared mutable state in error handling"
section (describing issues with package-level errors like herodot.ErrNotFound
and how the new API creates fresh error instances) should be extracted into a
shared include/snippet and referenced from each OEL changelog to avoid
duplication; create a single canonical snippet containing the explanatory text
about shared mutable error state, examples of impacted values (cookies, UUIDs,
OAuth2 hints, OIDC URLs, schema fetches, JWT claims), and the note about no
persistent write, then replace the repeated blocks in each changelog with a
short pointer/include to that snippet.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: f37d16e7-6fd7-47b2-97b8-a871f172d3b0
📒 Files selected for processing (5)
docs/self-hosted/oel/keto/changelog/v26.2.5.mddocs/self-hosted/oel/kratos/changelog/v26.2.5.mddocs/self-hosted/oel/oathkeeper/changelog/v26.2.5.mddocs/self-hosted/oel/oauth2/changelog/v26.2.5.mddocs/self-hosted/oel/polis/changelog/v26.2.5.md
ory-bot
force-pushed
the
oel-changelog-update
branch
from
ec037c1 to
d81df55
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (4)
docs/self-hosted/oel/oauth2/changelog/v26.2.5.md (1)
7-7:⚠️ Potential issue | 🟡 MinorPunctuation: use “etc.”
Line 7 should read
...details, etc., modified....🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/self-hosted/oel/oauth2/changelog/v26.2.5.md` at line 7, Fix the punctuation in the sentence fragment "details, etc, modified" by changing "etc" to the correct form "etc." and ensuring proper comma placement so the phrase reads "...details, etc., modified..."; update the occurrence in the changelog sentence (the fragment containing "reason text, details, etc, modified the global") accordingly.docs/self-hosted/oel/oathkeeper/changelog/v26.2.5.md (1)
7-7:⚠️ Potential issue | 🟡 MinorPunctuation: use “etc.”
Line 7 should use “etc.” (with period):
...details, etc., modified....🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/self-hosted/oel/oathkeeper/changelog/v26.2.5.md` at line 7, Replace the missing period after "etc" on the phrase "details, etc, modified" so it reads "details, etc., modified" — locate the sentence in the changelog entry containing "an error — reason text, details, etc, modified the global" and add the period after "etc" to correct punctuation.docs/self-hosted/oel/keto/changelog/v26.2.5.md (1)
12-12:⚠️ Potential issue | 🟡 MinorPunctuation: use “etc.”
Line 12 should be
...details, etc., modified...for standard abbreviation punctuation.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/self-hosted/oel/keto/changelog/v26.2.5.md` at line 12, Change the punctuation in the sentence fragment so the abbreviation “etc.” includes the closing period before the following comma; replace the phrase fragment "details, etc, modified" with "details, etc., modified" to conform to standard abbreviation punctuation.docs/self-hosted/oel/kratos/changelog/v26.2.5.md (1)
7-7:⚠️ Potential issue | 🟡 MinorPunctuation: use “etc.”
Line 7 should use
etc.(i.e.,...details, etc., modified...).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/self-hosted/oel/kratos/changelog/v26.2.5.md` at line 7, Fix the punctuation in the sentence fragment "an error — reason text, details, etc, modified the global" by changing "etc" to "etc." so the phrase reads "...details, etc., modified the global"; update the line in the changelog (the sentence containing "reason text, details, etc, modified the global") to include the period after "etc" and ensure spacing around the em dash remains unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@docs/self-hosted/oel/keto/changelog/v26.2.5.md`:
- Line 12: Change the punctuation in the sentence fragment so the abbreviation
“etc.” includes the closing period before the following comma; replace the
phrase fragment "details, etc, modified" with "details, etc., modified" to
conform to standard abbreviation punctuation.
In `@docs/self-hosted/oel/kratos/changelog/v26.2.5.md`:
- Line 7: Fix the punctuation in the sentence fragment "an error — reason text,
details, etc, modified the global" by changing "etc" to "etc." so the phrase
reads "...details, etc., modified the global"; update the line in the changelog
(the sentence containing "reason text, details, etc, modified the global") to
include the period after "etc" and ensure spacing around the em dash remains
unchanged.
In `@docs/self-hosted/oel/oathkeeper/changelog/v26.2.5.md`:
- Line 7: Replace the missing period after "etc" on the phrase "details, etc,
modified" so it reads "details, etc., modified" — locate the sentence in the
changelog entry containing "an error — reason text, details, etc, modified the
global" and add the period after "etc" to correct punctuation.
In `@docs/self-hosted/oel/oauth2/changelog/v26.2.5.md`:
- Line 7: Fix the punctuation in the sentence fragment "details, etc, modified"
by changing "etc" to the correct form "etc." and ensuring proper comma placement
so the phrase reads "...details, etc., modified..."; update the occurrence in
the changelog sentence (the fragment containing "reason text, details, etc,
modified the global") accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9c4fc00a-a62c-4720-86dd-0ca28f6fc4a4
📒 Files selected for processing (5)
docs/self-hosted/oel/keto/changelog/v26.2.5.mddocs/self-hosted/oel/kratos/changelog/v26.2.5.mddocs/self-hosted/oel/oathkeeper/changelog/v26.2.5.mddocs/self-hosted/oel/oauth2/changelog/v26.2.5.mddocs/self-hosted/oel/polis/changelog/v26.2.5.md
✅ Files skipped from review due to trivial changes (1)
- docs/self-hosted/oel/polis/changelog/v26.2.5.md
deepakprabhakara
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update OEL changelog
Summary by CodeRabbit
Release Notes – v26.2.5
Bug Fixes
New Features