chore: add AGENTS.md#2522
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@AGENTS.md`:
- Line 41: Update AGENTS.md to use consistent markdown spacing by adding a space
after label colons; specifically change label instances like
"Location:`/src/components/shared/<product>/...`" and any "possible:`...`"
occurrences so they read "Location: `/src/components/shared/<product>/...`" and
"possible: `...`" (also fix the same issue at the other occurrence reported
around line 104); ensure all similar label:value pairs in the file follow the
"Label: value" spacing convention.
- Around line 171-173: Replace the malformed canonical tag example that uses the
invalid token "linkrel" with a correct link element; locate the snippet showing
`<linkrel="canonical" href="..."/>` in AGENTS.md and change it to a proper
`<link rel="canonical" href="..." />` so the canonical link is valid HTML.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 2652a719-7562-4054-9666-01d2e3c96abf
📒 Files selected for processing (1)
AGENTS.md
There was a problem hiding this comment.
Pull request overview
Adds an AGENTS.md guide describing the repo’s transitional docs organization by deployment model (Network / OEL / OSS) and how contributors should structure shared content, shell pages, sidebars, and canonical URLs.
Changes:
- Introduces
AGENTS.mdwith guidance for migrated vs non-migrated docs sections. - Documents the shared-content vs deployment-shell pattern and sidebar responsibilities.
- Defines canonical URL rules for cross-deployment duplicated content.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bb5a77f to
78d0452
Compare
aeneasr
left a comment
There was a problem hiding this comment.
Can you add CLAUDE.md with contents @AGENTS.md so that claude picks up the agents file? It's the official workaround to get claude to read agents
vinckr
left a comment
There was a problem hiding this comment.
do we need to commit this here?
wouldn't it be enough for those that actually work on the docs to have locally/internally?
I strongly suggest putting this directly into the repo, so that everybody has the same, up-to-date rules all the time. The alternative is clearly worse: every dev needs to add this file to the repo locally, and keep it current with what we have in Notion. Rather, we should embrace this approach and not just add information about the structure, but also tone of voice, style guides, etc. |
the README.md has content on the style that should be followed. Couldn't you give that as context? The guidenace in the file committed here seems to be only for the ongoing migration and should not be relevant after that is done. in any case we need to have 1 source of truth for these rules and having multiple files (agents, readme) will make things more confusing not less. couldn't you point to the README like you did in Claude.md "see README.md" and then add these rules about the migration strategy there? |
There's important information in the doc that is not in the README, which made me want to add it in the first place. Specifically the whole section about the new structure is just documenting the structure, not the migration:
We can also put everything in README, I'm fine with that. I just want all documentation about the documentation structure to live in the repo, to be consumed by humans and agents alike. |
Add AGENTS.md with guidance on where to put what.
Summary by CodeRabbit