Skip to content

docs: remove closed reference to ory/hydra#3363#2525

Closed
q404365631 wants to merge 1 commit into
ory:masterfrom
q404365631:fix-closed-ref-hydra-3363
Closed

docs: remove closed reference to ory/hydra#3363#2525
q404365631 wants to merge 1 commit into
ory:masterfrom
q404365631:fix-closed-ref-hydra-3363

Conversation

@q404365631
Copy link
Copy Markdown

@q404365631 q404365631 commented Apr 24, 2026

Closes #2524

The upstream issue ory/hydra#3363 has been resolved. This PR removes the stale link from the MySQL migration troubleshooting section.

Summary by CodeRabbit

  • Documentation
    • Cleaned up deployment documentation by removing an outdated reference link.

Upstream issue is resolved. Removes the stale link from the MySQL migration troubleshooting section.

Closes ory#2524
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 24, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


q404365631 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1174053a-cc30-4f44-ae69-28e2dec3290a

📥 Commits

Reviewing files that changed from the base of the PR and between d5b42b0 and ac9e78d.

📒 Files selected for processing (1)
  • src/components/Shared/self-hosted/deployment.tsx
💤 Files with no reviewable changes (1)
  • src/components/Shared/self-hosted/deployment.tsx

📝 Walkthrough

Walkthrough

Removes an outdated reference to a closed upstream GitHub issue (Hydra #3363) from the "See also" hyperlink list in the deployment documentation component. The Kratos issue reference is retained.

Changes

Cohort / File(s) Summary
Closed Reference Cleanup
src/components/Shared/self-hosted/deployment.tsx
Removes the Hydra issue reference from the "See also" section, eliminating a link to a closed upstream issue while preserving the Kratos issue link.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A reference once useful now lies in the past,
Its upstream issue closed, no longer to last,
So out with the old link, we tidy with care,
Keeping what matters, removing the wear! 🧹✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: removing a closed reference to a specific Hydra issue from documentation.
Description check ✅ Passed The description is minimal but sufficient for a documentation fix, mentioning the closed issue and affected section. However, it lacks the structured format of the template with explicit sections.
Linked Issues check ✅ Passed The PR directly addresses the requirements in issue #2524 by removing the stale reference to ory/hydra#3363 from the MySQL migration troubleshooting section.
Out of Scope Changes check ✅ Passed The changes are narrowly scoped to removing a single closed reference, with no extraneous modifications beyond the stated objective of removing the stale Hydra issue link.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@vinckr
Copy link
Copy Markdown
Member

vinckr commented Apr 24, 2026

hello @q404365631 thanks for this cleanup - please do sign the CLA so we can satisfy our CI and review/merge this.

@aeneasr
Copy link
Copy Markdown
Member

aeneasr commented Apr 28, 2026

Bullshit submission, the reference is there for people who have the problem. Removing it removes value for people who have this problem. Clearly botted

@aeneasr aeneasr closed this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upstream reference closed: github.com/ory/hydra/issues/3363

4 participants