Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validation message regression #380

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

pcaillaudm
Copy link
Contributor

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.45%. Comparing base (f3fad4d) to head (fe61c9a).
Report is 55 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
+ Coverage   42.43%   49.45%   +7.02%     
==========================================
  Files         136      140       +4     
  Lines        2008     2192     +184     
  Branches      288      332      +44     
==========================================
+ Hits          852     1084     +232     
+ Misses       1149     1095      -54     
- Partials        7       13       +6     
Components Coverage Δ
@ory/elements-react 46.11% <33.78%> (+9.32%) ⬆️
@ory/nextjs 64.33% <74.24%> (-1.65%) ⬇️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcaillaudm pcaillaudm merged commit 297f50f into main Mar 7, 2025
14 checks passed
@pcaillaudm pcaillaudm deleted the pcaillaudm/fix/fix-validation-message-regression branch March 7, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants