Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly render test id for error card #386

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

jonas-jonas
Copy link
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.08%. Comparing base (f3fad4d) to head (2a86f0b).
Report is 64 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
+ Coverage   42.43%   49.08%   +6.65%     
==========================================
  Files         136      141       +5     
  Lines        2008     2239     +231     
  Branches      288      341      +53     
==========================================
+ Hits          852     1099     +247     
+ Misses       1149     1127      -22     
- Partials        7       13       +6     
Components Coverage Δ
@ory/elements-react 45.75% <34.72%> (+8.96%) ⬆️
@ory/nextjs 64.33% <74.24%> (-1.65%) ⬇️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jonas-jonas jonas-jonas merged commit bee1751 into main Mar 12, 2025
14 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/fixErrorTestId branch March 12, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant