Skip to content

feat: feature-flag min pool#10

Merged
aeneasr merged 1 commit intomainfrom
conn-pool
Oct 10, 2025
Merged

feat: feature-flag min pool#10
aeneasr merged 1 commit intomainfrom
conn-pool

Conversation

@aeneasr
Copy link
Member

@aeneasr aeneasr commented Oct 10, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 10, 2025 08:16
@aeneasr aeneasr requested a review from a team as a code owner October 10, 2025 08:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a feature flag to control the minimum connection pool functionality for PostgreSQL and CockroachDB connections. The change introduces a new AllowMinPool field to the ConnectionDetails struct that acts as a gate for enabling the pgx pool feature when the pool_min_conns parameter is present in the DSN.

  • Added AllowMinPool boolean field to ConnectionDetails struct
  • Updated connection logic to check the feature flag before enabling min pool functionality

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
connection_details.go Adds AllowMinPool field to ConnectionDetails struct
connection_instrumented.go Updates pool creation logic to check AllowMinPool flag

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@aeneasr aeneasr merged commit 02f3e5f into main Oct 10, 2025
8 checks passed
@aeneasr aeneasr deleted the conn-pool branch October 10, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants