Use more signatures in OpenQA::Utils and simplify #6357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
okurz
commented
Apr 3, 2025
okurz
commented
- Use more signatures in OpenQA::Utils
- Simplify Utils::get_url_short
- Use signatures in Utils::get_url_short
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6357 +/- ##
==========================================
- Coverage 99.05% 99.05% -0.01%
==========================================
Files 399 399
Lines 40123 40117 -6
==========================================
- Hits 39743 39737 -6
Misses 380 380 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
perlpunk
reviewed
Apr 3, 2025
Martchus
approved these changes
Apr 3, 2025
Co-authored-by: Tina Müller (tinita) <[email protected]>
perlpunk
approved these changes
Apr 3, 2025
Wabri
approved these changes
Apr 3, 2025
Comment on lines
-559
to
+556
| my ($arg) = @_; | ||
| return ('', 0) unless ($arg =~ /_URL$/); | ||
| my $short; | ||
| my $do_extract = 0; | ||
| if ($arg =~ /_DECOMPRESS_URL$/) { | ||
| $short = substr($arg, 0, -15); | ||
| $do_extract = 1; | ||
| } | ||
| else { | ||
| $short = substr($arg, 0, -4); | ||
| } | ||
| return ($short, $do_extract); | ||
| return ('', 0) unless $arg =~ s/_URL$//; | ||
| return $arg =~ s/_DECOMPRESS$// ? ($arg, 1) : ($arg, 0); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.