Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install SLES 16.0 Minimal VM as guest on SLES 16.0 system #21142

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

waynechen55
Copy link
Contributor

@waynechen55 waynechen55 commented Feb 7, 2025

  • New module tests/virt_autotest/prepare_non_transactional_server.pm to perform all necessary or potential operations on non-transactional system before doing actual work like virtual machine installation. These operations may involve extra packages installation, product and extension registration, grub modification and many others.

  • New subroutine is_reboot_needed in lib/utils.pm to determine whether system reboot is needed after changes being made. It uses setting NEEDS_REBOOTING or returned code of zypper needs-rebooting to judge whether reboot is really needed.

  • New guest profile data/virt_autotest/guest_params_xml_files/sles_16_64_kvm_hvm_x86_64_qcow_ignition+combustion.xml to represent SLES 16.0 Minimal VM for x86_64.

  • New combustion script data/virt_autotest/guest_unattended_installation_files/combustion_script_all_round to perform all necessary tasks, including adding user, setting passwords, adding ssh public keys, starting services, doing registration and etc, in order to have a fully up and running system. This is useful especially when ignition does not work very well.

  • Introduce new test suite level setting UNIFIED_GUEST_BUILDS for unified guest installation because SLES 16.0 Minimal VM may have different build than agama installer.

  • Update virtualization server patterns for SLES 16.0.

  • Use ##Authorized-Keys## and ##FQDN## in combustion_script_all_round.

  • New subroutine install_extra_packages in lib/utils.pm to wrap up already existing similar functionality in multiple modules, for example, tests/virt_autotest/prepare_non_transactional_server.pm and tests/virt_autotest/prepare_transactional_server.pm.

  • Verification Runs:

@waynechen55 waynechen55 marked this pull request as draft February 7, 2025 10:27
Copy link

github-actions bot commented Feb 7, 2025

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@waynechen55 waynechen55 force-pushed the wayne/install_sles16_iso_as_guest branch 3 times, most recently from 12d728a to fbea714 Compare February 7, 2025 11:05
1.New module prepare_non_transactional_server.pm to perform all
necessary operations on non-transactional system before doing
actual work like virtual machine installation.
2.New subroutine is_reboot_needed in lib/utils.pm to determine
whether system reboot is needed after changes being made. It uses
setting NEEDS_REBOOTING or returned code of zypper needs-rebooting
to judge whether reboot is needed.
3.New guest profile sles_16_64_kvm_hvm_x86_64_qcow_ignition+combustion.xml
to represent SLES 16.0 Minimal VM for x86_64.
4.New combustion script combustion_script_all_round to perform all
necessary tasks, including adding user, setting passwords, adding
ssh public keys, starting services, doing registration and etc, in
order to have a fully up and running system.
5.Introduce new test suite level setting UNIFIED_GUEST_BUILDS for
unified guest installation because SLES 16.0 Minimal VM may have
different build than agama installer.
6.Update virtualization server patterns for SLES 16.0.
7.Use ##Authorized-Keys## and ##FQDN## in combustion_script_all_round.
8.New subroutine install_extra_packages in lib/utils.pm to wrap
up already existing similar functionality in multiple modules.
@waynechen55 waynechen55 force-pushed the wayne/install_sles16_iso_as_guest branch from fbea714 to 3d289a9 Compare February 7, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant