-
Notifications
You must be signed in to change notification settings - Fork 7
Added taskfile #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added taskfile #265
Conversation
52a3346 to
518d7b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check commands should not apply changes
Taskfile.yml
Outdated
| - docker compose run --rm --volume "$PWD:/md" markdownlint markdownlint --ignore '**/node_modules/**' --ignore '**/vendor/**' '*.md' 'documentation/*.md' --fix | ||
|
|
||
| coding-standards:markdown:check: | ||
| desc: "Apply and check coding standards for Markdown" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should only check markdown standards
Taskfile.yml
Outdated
| coding-standards:yml:check: | ||
| desc: Apply coding standards for yml | ||
| cmds: | ||
| - docker compose run --rm --volume "$PWD:/md" prettier '**/*.{yml,yaml}' --write |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should only check
Taskfile.yml
Outdated
| coding-standards:assets:check: | ||
| desc: Apply and check coding standards for assets | ||
| cmds: | ||
| - task coding-standards:assets:apply |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should only check
Taskfile.yml
Outdated
| - task compose -- pull | ||
| - task compose-up | ||
| - task composer-install | ||
| - task npm-install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm-install before
task compose-up
so dependencies are ready for compose-up
Taskfile.yml
Outdated
| coding-standards:php:check: | ||
| desc: "Apply and check coding standards for PHP" | ||
| cmds: | ||
| - task coding-standards:php:apply |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only check
26656d0 to
58700d1
Compare
Link to issue
#249
Link to ticket
https://leantime.itkdev.dk/?tab=ticketdetails#/tickets/showTicket/5289
Description
Taskfile added, somewhat copy pasted from different places
Screenshot of the result
🖼️