Skip to content

Conversation

@sinejespersen
Copy link
Contributor

@sinejespersen sinejespersen commented Aug 27, 2025

Link to issue

#249

Link to ticket

https://leantime.itkdev.dk/?tab=ticketdetails#/tickets/showTicket/5289

Description

Taskfile added, somewhat copy pasted from different places

Screenshot of the result

🖼️

@sinejespersen sinejespersen force-pushed the feature/5289-taskfile branch 2 times, most recently from 52a3346 to 518d7b2 Compare August 27, 2025 19:20
@sinejespersen sinejespersen requested a review from tuj August 27, 2025 19:21
@sinejespersen sinejespersen self-assigned this Aug 27, 2025
Copy link
Contributor

@tuj tuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check commands should not apply changes

Taskfile.yml Outdated
- docker compose run --rm --volume "$PWD:/md" markdownlint markdownlint --ignore '**/node_modules/**' --ignore '**/vendor/**' '*.md' 'documentation/*.md' --fix

coding-standards:markdown:check:
desc: "Apply and check coding standards for Markdown"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only check markdown standards

Taskfile.yml Outdated
coding-standards:yml:check:
desc: Apply coding standards for yml
cmds:
- docker compose run --rm --volume "$PWD:/md" prettier '**/*.{yml,yaml}' --write
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only check

Taskfile.yml Outdated
coding-standards:assets:check:
desc: Apply and check coding standards for assets
cmds:
- task coding-standards:assets:apply
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only check

Taskfile.yml Outdated
- task compose -- pull
- task compose-up
- task composer-install
- task npm-install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm-install before

task compose-up

so dependencies are ready for compose-up

Taskfile.yml Outdated
coding-standards:php:check:
desc: "Apply and check coding standards for PHP"
cmds:
- task coding-standards:php:apply
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only check

@tuj tuj added the enhancement New feature or request label Aug 28, 2025
@tuj tuj added this to the 3.0.0 milestone Aug 28, 2025
@sinejespersen sinejespersen force-pushed the feature/5289-taskfile branch from 26656d0 to 58700d1 Compare August 28, 2025 07:05
@sinejespersen sinejespersen requested a review from tuj August 28, 2025 07:06
@tuj tuj changed the title 5289: taskfile added Added taskfile Aug 28, 2025
@tuj tuj merged commit 43796f0 into release/3.0.0 Aug 28, 2025
17 checks passed
@tuj tuj deleted the feature/5289-taskfile branch August 28, 2025 17:37
@tuj tuj mentioned this pull request Aug 28, 2025
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants