Handle truncated pr_fname #484
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenns10
force-pushed
the
fix_truncated_fname
branch
2 times, most recently
from
03c7671 to
ea677ec
Compare
|
It wouldn't be a PR from me if I didn't force-push it 3 times in rapid succession 😭 sorry lol |
brenns10
force-pushed
the
fix_truncated_fname
branch
from
ea677ec to
0723df9
Compare
It appears that some core dumps may have a "pr_fname" which isn't nul-terminated, which leads to the following exception, even if you're not interested in the thread name: >>> next(prog.threads()).stack_trace() Traceback (most recent call last): File "<console>", line 1, in <module> Exception: pr_fname is not null terminated Handle this by creating a copy and nul-terminating it. Closes: osandov#483 Fixes: e6cc9b0 ("Add name to drgn.Thread") Signed-off-by: Stephen Brennan <[email protected]>
brenns10
force-pushed
the
fix_truncated_fname
branch
from
0723df9 to
9240cae
Compare
|
Sorry for all that noise. Realizing I really need to code-review myself before sending the PR. It's funny, the Github UI is apparently much easier for my to review my own code in, rather than the editor/git log. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that some core dumps may have a "pr_fname" which isn't nul-terminated, which leads to the following exception, even if you're not interested in the thread name:
Handle this by creating a copy and nul-terminating it.
Closes: #483
Fixes: e6cc9b0 ("Add name to drgn.Thread")