Repository navigation
many: pass on install_langs to RPM - #1857
Merged
Merged
Conversation
The osbuild RPM stage allows defining `install_langs` but this is not currently possible on the RPM stage wrapper in `images`. Let's add the capability. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Wire up the previously added new `InstallLangs` RPM stage option all the way into the image config so it can be written there. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
mvo5
reviewed
Sep 11, 2025
mvo5
left a comment
mvo5
left a comment
Contributor
There was a problem hiding this comment.
Thank you, this looks fine to me. But I would like to see a test for it too (see inline suggestion)
|
|
||
| // InstallLangs determines which locales are installed by RPM, the default | ||
| // is `all`. | ||
| InstallLangs []string `yaml:"install_langs,omitempty"` |
Contributor
There was a problem hiding this comment.
(nitpick) just to double check the comment - the default is the empty string which means "all", right?
Member
Author
There was a problem hiding this comment.
The default is empty slice of strings which then doesn't get into the JSON which in the stage means don't set the macro at all which in RPM means it uses the default 'all'.
lzap
previously approved these changes
Sep 11, 2025
Add a test case to ensure `InstallLangs` ends up in the appropriate place in the RPM stage options. Co-Authored-By: Michael Vogt <michael.vogt@gmail.com> Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Member
Author
|
I've added the test case in a separate commit with the appropriate co-authored-by. This means this PR needs to be re-acked. |
lzap
approved these changes
Sep 11, 2025
achilleas-k
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
osbuildwe have the capability to set the_install_langsmacro in the stage options. This was never wired through intoimages. This PR wires it up intoimage_configso it can be set.This saves about 90 MiB on a small installation I'm working on in my spare time.