Repository navigation
progress: add file progress (HMS-10977) - #2493
Merged
Merged
Conversation
croissanne
commented
Jul 7, 2026
croissanne
commented
Member
croissanne
requested review from
avitova,
lzap and
supakeen
and removed request for
avitova,
lzap and
supakeen
July 7, 2026 11:12
croissanne
marked this pull request as draft
July 7, 2026 11:13
croissanne
force-pushed
the
json-progress
branch
3 times, most recently
from
July 7, 2026 15:59
7633239 to
40ba6f3
Compare
croissanne
marked this pull request as ready for review
July 7, 2026 16:31
supakeen
reviewed
Jul 8, 2026
croissanne
marked this pull request as draft
July 8, 2026 10:31
croissanne
force-pushed
the
json-progress
branch
4 times, most recently
from
July 8, 2026 11:03
86e12ce to
7cba8cb
Compare
croissanne
marked this pull request as ready for review
July 8, 2026 11:15
The output directory needs to be created before creating the progress bar, as the file progress will write to a file inside of the output directory.
This progress "bar" creates a file in the output directory ending with ".progress". The file only contains the last status, meaning it is truncated each time. Each entry is a valid JSON struct. Regular messages without progress are ignored. Finally, no subprogress is printed without the context of the progress above (for instance the progress of overal pipelines and the stages within the currently running pipeline will be contained in a single statement). This progress type is intended for cockpit-image-builder, so it was modeled after the progress information currently returned by composer.
achilleas-k
approved these changes
Jul 9, 2026
supakeen
approved these changes
Jul 9, 2026
avitova
approved these changes
Jul 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 9, 2026
Member
|
Adding to the merge queue again. The failure should be fixed by #2467 (which is already on the queue right now). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.