Repository navigation
osinfo: read blueprints from variants - #2754
Merged
Merged
Conversation
Use the `blueprint.*` name as preferred over `config.*`, read from variant paths (same as `disk.yaml` and `iso.yaml`) *and* document the availability. Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
croissanne
force-pushed
the
blueprint-variants
branch
from
October 9, 2026 12:13
e6e995e to
b702c3a
Compare
Member
|
Rebased to make it green. |
This was referenced Oct 9, 2026
croissanne
approved these changes
Oct 9, 2026
| config, err = blueprintload.LoadFS(fsys, path.Join(prefix, "config.toml")) | ||
| if err != nil && !os.IsNotExist(err) { | ||
| return nil, err | ||
| func readImageCustomization(fsys fs.FS, prefix, variant string) (*blueprint.Customizations, error) { |
Member
There was a problem hiding this comment.
Not at all a blocker, but I wonder if it could throw an error or warning for ignored blueprint entries/customizations here.
achilleas-k
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the
blueprint.*name as preferred overconfig.*, read from variant paths (same asdisk.yamlandiso.yaml) and document the availability.