Repository navigation
Conversation
The sysext extras by default already layered on top of the reference pipeline (usually the OS pipeline) for their RPM transaction. This means that the sysext installs *all* RPMs from the reference pipeline plus any additional ones. This was on purpose since it's easy to reason about and it shows that the naive implementation works. When `standalone` is turned on we don't do that and instead resolve the RPM transaction for the sysext separately. Change the default behavior for non-standalone sysexts to copy in the reference tree (so the RPM database and interpreters necessary for scriptlets are present) and then cut down the to-be-installed RPMs by taking the subset of those that weren't already installed in the reference pipeline. This really speeds up builds and due to the transaction nature of the depsolver we can guarantee that we can build on top of the reference pipeline in this way. Some numbers, for an image type that layers three sysexts (`podman`, `weechat`, and `tmux`): - Before: 7m08s total. - After: 4m13s total. The latter is basically the same time as the build without any system extensions. Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sysext extras by default already layered on top of the reference pipeline (usually the OS pipeline) for their RPM transaction. This means that the sysext installs all RPMs from the reference pipeline plus any additional ones. This was on purpose since it's easy to reason about and it shows that the naive implementation works.
When
standaloneis turned on we don't do that and instead resolve the RPM transaction for the sysext separately.Change the default behavior for non-standalone sysexts to copy in the reference tree (so the RPM database and interpreters necessary for scriptlets are present) and then cut down the to-be-installed RPMs by taking the subset of those that weren't already installed in the reference pipeline.
This really speeds up builds and due to the transaction nature of the depsolver we can guarantee that we can build on top of the reference pipeline in this way.
Some numbers, for an image type that layers three sysexts (
podman,weechat, andtmux):The latter is basically the same time as the build without any system extensions.