Introduce global gap variable Oscar_jl
#4577
Conversation
| ############################################################################ | ||
|
|
||
| # Use GAP operations for the serialization of GAP objects. | ||
| # (The methods will be Julia functions.) |
There was a problem hiding this comment.
The comment lines do not fit.
If we want to make a comment then perhaps "for backwards compatibility"?
There was a problem hiding this comment.
Oops, yes, I just copied the block from above but forgot to update it. Will do that tomorrow
| @@ -123,14 +123,14 @@ InstallMethod(SetNiceMorphismForJuliaMatrixRepGroup, [IsGroup], function(G) | |||
| Assert(0, ForAll(gens, IsJuliaMatrixRep)); | |||
|
|
|||
| ele := gens[1]; | |||
| hom := Julia.Oscar.iso_oscar_gap(Julia.base_ring(ele!.m)); | |||
| hom := Oscar_jl.iso_oscar_gap(Julia.base_ring(ele!.m)); | |||
There was a problem hiding this comment.
We get warnings about Oscar_jl being unbound here. I think this might be caused by this code being loaded before Oscar.jl ?
The easiest way to fix this would be to move this file into OscarInterface.
There was a problem hiding this comment.
(and then edit experimental/MatrixGroups/src/MatrixGroups.jl to remove its __init__ method)
There was a problem hiding this comment.
I think this is a general rule:
Any additional GAP code inside Oscar that shall become available in Oscar should be read via OscarInterface.
(If this is the case then perhaps it should be mentioned in the manual section "Interface functionalities beyond GAP.jl".)
fingolfin
added
the
release notes: not needed
Motivated by
from oscar-system/GAP.jl#1053.