Add Places Serializer Field#49
Open
minifisk wants to merge 15 commits into
Open
Conversation
minifisk
changed the title
Owner
|
Wow!! this looks cool! I'm gonna add some fixes so we can make the rest-framework dependency optional. |
Author
|
Can't merge due to commits needed to be verified. Didn't manage to set this up on my computer, maybe can solve this in some way? @oscarmcm |
Owner
|
Yeah I'll merge it locally and/or squash all the commits into one |
Author
|
Commited a fix, causing wrong order of city and country |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is expected to cater those users building a API with Django-rest-framework and want to use the location field in their responses.
This PR introduces the
PlacesSerializerFieldto improve the handling of geolocation data in our Django application. The field manages comma-separated geolocation strings, providing structured output and ensuring data integrity.Key Changes:
PlacesSerializerFieldinserializers.py, supporting the format "country,city,latitude,longitude".to_representationandto_internal_valuemethods.djangorestframework.Testing:
PlacesSerializerField, covering various input scenarios.Dependencies:
djangorestframeworkto enhance API capabilities.