Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(file):add rye to SciCookie #260

Closed
wants to merge 4 commits into from

Conversation

Satarupa22-SD
Copy link
Contributor

Pull Request description

This pull request adds Rye, a comprehensive project and package management solution for Python, as a build system dependency to the project.

Resolves #258

How to test these changes

Updated the pyproject.toml file to include rye>=0.4.1 in the [build-system] requires section.

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

@Satarupa22-SD
Copy link
Contributor Author

@xmnlab

@xmnlab
Copy link
Member

xmnlab commented Apr 9, 2024

Hi @Satarupa22-SD thanks for working on that.

Actually the idea was to add rye as an option to the build systems to the template.

I opened that issue just to keep that in the discussion, that is why I didnt add details. Sorry about that.

Do you think you could add it as an option to the template build system, instead of to the root of the project?

@xmnlab xmnlab marked this pull request as draft April 25, 2024 16:31
@xmnlab
Copy link
Member

xmnlab commented Oct 7, 2024

@Satarupa22-SD I am closing this PR, feel free to reopen this if you have more updates. thanks!

@xmnlab xmnlab closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rye, a comprehensive project and package management solution for Python
2 participants