Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix issues with dependencies and default tools #274

Merged
merged 13 commits into from
May 3, 2024

Conversation

xmnlab
Copy link
Member

@xmnlab xmnlab commented May 3, 2024

Pull Request description

This PR aims to fix issues about the location where the dev dependencies is defined in the pyproject.toml file.
additionally, it fixes some small issues about the default libraries and improve the contributing guide.

How to test these changes

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved

@xmnlab
Copy link
Member Author

xmnlab commented May 3, 2024

@Saransh-cpp @Anavelyz @EverVino ,
I am merging this PR now because @lwasser found some issues that will block her PR #273

@xmnlab xmnlab merged commit ed65b11 into osl-incubator:main May 3, 2024
12 checks passed
@xmnlab xmnlab deleted the fix-deps-issues branch May 3, 2024 05:03
Copy link

github-actions bot commented May 3, 2024

🎉 This PR is included in version 0.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant