enrich irve socket max output #2571
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tykayn
force-pushed
the
feat/irve-enrich-2
branch
2 times, most recently
from
8a63ea2 to
e60258e
Compare
tykayn
force-pushed
the
feat/irve-enrich-2
branch
from
50ea73e to
0ffd8c2
Compare
|
Please, can you rework your PR in order to minimize code changes. Include only english comment to code. |
tykayn
force-pushed
the
feat/irve-enrich-2
branch
from
fd2a6f1 to
6ee895c
Compare
tykayn
force-pushed
the
feat/irve-enrich-2
branch
from
6ee895c to
103f219
Compare
|
@frodrigo i updated the branch to minimize changes and translated comments in English |
frodrigo
reviewed
Sep 2, 2025
| ) | ||
| except Exception: | ||
| return None | ||
| return f"{self._normalize_number(v)} kW" |
There was a problem hiding this comment.
Move the f-string to _normalize_number function, to simplify the code.
Suggested change
| return f"{self._normalize_number(v)} kW" | |
| return f"{self._normalize_number(v)} kW" |
frodrigo
reviewed
Sep 2, 2025
| if raw is None: | ||
| return None | ||
|
|
||
| s = str(raw).strip() |
There was a problem hiding this comment.
raw is not alredy a string ?
frodrigo
reviewed
Sep 2, 2025
| if s == "": | ||
| return None | ||
|
|
||
| max_kw = getattr(self, "MAX_POWER_KW", 500) |
There was a problem hiding this comment.
It s class attrib, will be defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes values that are more than the max known of 400kW to be set as the max power output of a charging station, adds a tag to correct values.
Also handles enumerations of this values to keep the maximum value.
The column evaluated in the dataset of French IRVE is "puissance_nominale" by the function "getPuissanceNominaleInKw".
Tested locally with docker on Monaco and Ile de France zones, returns proposals for the "charging_station:output" tag as "n kW" when finding good values.