Delete the governance proposal code for creating a CL pool

[ValarDragon]

I've left the codec for decoding until we come back with an answer for removing things from codec or not

[coderabbitai]

Walkthrough

This pull request removes concentrated liquidity pool proposal functionality across the codebase. It deletes related proposal handlers, CLI commands, keeper methods, proposal types, constants, and associated tests while retaining functionality for tick spacing decrease proposals. Additionally, a field is removed from a protobuf message and replaced with a reserved statement. A TODO comment was added to the codec registration as a reminder for future revisions.

Changes

File(s)	Change Summary
app/keepers/modules.go, app/app.go, x/concentrated-liquidity/client/cli/tx.go, x/concentrated-liquidity/client/proposal_handler.go, x/concentrated-liquidity/gov.go, x/concentrated-liquidity/types/gov.go, x/concentrated-liquidity/types/gov_test.go	Removal of all components related to the CreateConcentratedLiquidityPoolsProposal: proposal handler, CLI command and parsing, keeper method, proposal type registration, constant definitions, and associated tests.
proto/osmosis/concentratedliquidity/v1beta1/gov.proto	Removed the exponent_at_price_one field from the PoolRecord message and replaced it with a reserved statement for field number 4.
x/concentrated-liquidity/types/codec.go	Added a TODO comment regarding the registration of the removed proposal in the codec.
x/concentrated-liquidity/client/cli/flags.go	Removed the constant FlagPoolRecords.
tests/e2e/configurer/chain/chain.go	Removed the SubmitCreateConcentratedPoolProposal method, eliminating proposal submission logic.
tests/e2e/e2e_cl_test.go	Refactored pool creation and validation logic, replacing the proposal submission method with direct pool creation calls and simplifying assertions.

Possibly related PRs

• Delete Superfluid CL migration code #9011: The changes in the main PR, which involve the removal of the CreateConcentratedLiquidityPoolProposalHandler and related functionalities for concentrated liquidity pools, are directly related to the changes in the retrieved PR, which also focuses on the removal of migration code for concentrated liquidity positions, indicating a broader elimination of functionalities associated with concentrated liquidity pools.

Suggested reviewers

• mattverse
• PaddyMc
• AlpinYukseloglu
• czarcas7ic

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c869e0b and 363c650.

📒 Files selected for processing (2)

• tests/e2e/e2e_cl_test.go (3 hunks)
• tests/e2e/e2e_test.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: go-split-test-files
• GitHub Check: e2e
• GitHub Check: check-proto
• GitHub Check: Run golangci-lint
• GitHub Check: Summary

🔇 Additional comments (5)

tests/e2e/e2e_test.go (1)

67-69: Aligned test case name with implementation changes

This change reflects the removal of the governance proposal functionality for creating concentrated liquidity pools, renaming the test case and method call from "CreateConcentratedLiquidityPoolVoting_And_TWAP" to "ConcentratedLiquidityPoolTWAP" to accurately represent the updated implementation in e2e_cl_test.go.

tests/e2e/e2e_cl_test.go (4)

31-31: Renamed method to match updated test case name

The method name has been updated to reflect the removal of the governance proposal mechanism for pool creation, aligning with the test case name change in e2e_test.go.

---

41-50: Simplified pool creation to use direct method instead of governance proposals

The implementation has been significantly refactored to:

1. Use permissionless pool creation via a new helper method
2. Directly create the pool with CreateConcentratedPool instead of using governance proposals
3. Validate pool properties with immediate assertions instead of eventually consistent checks

This aligns with the PR objective of removing governance proposal code for creating CL pools.

---

123-137: Added helper method to ensure permissionless CL pool creation is enabled

This new helper method checks the current parameter for permissionless pool creation and updates it if necessary, ensuring that pools can be created without using governance proposals. The implementation includes proper error handling and validation.

---

157-157: Reused permissionless CL helper method

The method call was updated to use the newly extracted enablePermissionlessCL helper method, maintaining consistency with the other implementation changes.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[czarcas7ic]

Approving, assuming our state compatibility checks pass

[ValarDragon]

Wont be state compatible alas