Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: delete unused Power function in osmomath (backport #9045) #9046

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 11, 2025

Deletes the unused Power function in osmomath/decimal.go and its test in decimal_test.go, as this function is not currently in use and is never called within the codebase. PowerInteger remains intact for integer exponents.

Closes #3800


This is an automatic backport of pull request #9045 done by Mergify.

* refactor: comment out unused Power function in osmomath

This commit comments out the unused Power function in osmomath/decimal.go
and its test in decimal_test.go, as this function is not currently in use
and is never called within the codebase. PowerInteger remains intact for
integer exponents.

Closes #3800

* refactor: completely remove Power function documentation

This commit removes the commented out Power function completely, rather
than just commenting it out. This is a cleaner approach as it removes
dead code entirely.

(cherry picked from commit 135a129)
Copy link
Contributor

Important Notice

This PR modifies an in-repo Go module. It is one of:

  • osmomath
  • osmoutils
  • x/ibc-hooks
  • x/epochs

The dependent Go modules, especially the root one, will have to be
updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

  1. Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
  2. Provide the current branch name
  3. On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

@PaddyMc PaddyMc merged commit b52813c into v28.x Mar 11, 2025
20 checks passed
@PaddyMc PaddyMc deleted the mergify/bp/v28.x/pr-9045 branch March 11, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants