-
Notifications
You must be signed in to change notification settings - Fork 100
Model submission for x500 sensor configuration 1 from CTU-CRAS-NORLAB. #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model submission for x500 sensor configuration 1 from CTU-CRAS-NORLAB. #811
Conversation
submitted_models/ctu_cras_norlab_x500_sensor_config_1/model.sdf
Outdated
Show resolved
Hide resolved
Fix path to mesh in URDF
Fix spawning the UAV in example world
That is a great vehicle. Very nicely done. A possible suggested change for your simulated rgbd cameras is below. The changes are:
It might also make sense to update the FOV of your front camera to match the lens you plan to use. |
Thanks! The proposed changes are reasonable. I integrated them in 0aae069.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initial assessment of the CTU-CRAS-NORLAB x500 model is complete however there are some issues to resolve before this model can be merged and utilized in a competitive setting:
- Please separate the modifications to other UAV submitted models into a separate PR.
- Please clarify the discrepancy between the field-of-view of the lens in the
specifications.md
file and the HD camera in themodel.sdf
. - Please add a barometer and magnetometer to the model's
model.sdf
file. - Please address all comments in the
model.sdf
file.
Please address the issues noted above in this pull request. Once the above issues are fixed, your submission will move on to the next review stage!
submitted_models/ctu_cras_norlab_x500_sensor_config_1/model.sdf
Outdated
Show resolved
Hide resolved
submitted_models/ctu_cras_norlab_x500_sensor_config_1/model.sdf
Outdated
Show resolved
Hide resolved
Bounding box |
…cras_norlab_x500_sensor_config_1
Thank you for the review. All mentioned issues have been addressed:
|
Thank you for your submission. The submission process for this model will be completed in #853. |
This PR contains the submission of our x500 quadrotor aerial vehicle with custom controller with added feedforward acceleration and jerk. The controller was forked from the original controller and works the same way when supplied with
cmd_vel
twist. In addition to thecmd_vel
input, the feedforward acceleration and jerk can be supplied to improve the performance of the controller. Please see details about the controller in README.md.We believe that other teams' UAVs could also benefit from this improved controller. Let us know, whether you prefer us submitting the controller in a separate package.