-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lottery Factor Line Graph: Pattern and date range removal #688
Conversation
What specifically are you removing here? I pulled your branch and it still has the date-picker but not the threshold range-slider or the bot pattern matcher. |
@JamesKunstle let me go check when I get back to my computer. It should be removing the date range picker and patterns so something might have gotten messed up when I pushed. Threshold 100% should be there so something definitely isn't right on my end |
@JamesKunstle This is what I see when I run it locally. Let me know if you are seeing something different |
@cdolfi Yeah that's not what I'm seeing- lemme make sure that I fully rebuild and everything |
@cdolfi I confirmed that I'm starting 8Knot with the commit that's top of this branch, could you confirm that you've pushed all of your changes? |
@JamesKunstle This PR is for the Lottery Factor line graph not the project velocity visualization |
@cdolfi My bad, I swapped the two in my head and was looking at the date picker / value adjustment boxes. I confirmed that the lottery factor viz renders and behaves as expected on my end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checks out locally and in review, nothing to add.
This graph did/does not have the same bug that the pie chart had. During this audit it was discovered that the date range functionality was broken. After viewing this graph with a project with a 10+ year history, I found this feature unnecessary. In this pr I removed the date picker for reasons above and the pattern selector as that is prior implementation of github bots. Old viz for reference: