Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lottery Factor Line Graph: Pattern and date range removal #688

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

cdolfi
Copy link
Collaborator

@cdolfi cdolfi commented Apr 5, 2024

This graph did/does not have the same bug that the pie chart had. During this audit it was discovered that the date range functionality was broken. After viewing this graph with a project with a 10+ year history, I found this feature unnecessary. In this pr I removed the date picker for reasons above and the pattern selector as that is prior implementation of github bots. Old viz for reference:
Screenshot 2024-04-05 at 1 30 55 PM

@cdolfi cdolfi requested a review from JamesKunstle April 5, 2024 17:31
@cdolfi cdolfi added this to the OSS NA Critical Bugs/ TODOs milestone Apr 5, 2024
@cdolfi cdolfi linked an issue Apr 5, 2024 that may be closed by this pull request
@JamesKunstle
Copy link
Contributor

What specifically are you removing here? I pulled your branch and it still has the date-picker but not the threshold range-slider or the bot pattern matcher.

@cdolfi
Copy link
Collaborator Author

cdolfi commented Apr 9, 2024

@JamesKunstle let me go check when I get back to my computer. It should be removing the date range picker and patterns so something might have gotten messed up when I pushed. Threshold 100% should be there so something definitely isn't right on my end

@cdolfi
Copy link
Collaborator Author

cdolfi commented Apr 10, 2024

@JamesKunstle This is what I see when I run it locally. Let me know if you are seeing something different
Screenshot 2024-04-09 at 4 56 18 PM

@JamesKunstle
Copy link
Contributor

@cdolfi Yeah that's not what I'm seeing- lemme make sure that I fully rebuild and everything

@JamesKunstle
Copy link
Contributor

@cdolfi I confirmed that I'm starting 8Knot with the commit that's top of this branch, could you confirm that you've pushed all of your changes?

Screenshot 2024-04-10 at 12 06 27 PM

@cdolfi
Copy link
Collaborator Author

cdolfi commented Apr 10, 2024

@JamesKunstle This PR is for the Lottery Factor line graph not the project velocity visualization

@cdolfi cdolfi changed the title Pattern and date range removal Lottery Factor Line Graph: Pattern and date range removal Apr 10, 2024
@JamesKunstle
Copy link
Contributor

@cdolfi My bad, I swapped the two in my head and was looking at the date picker / value adjustment boxes. I confirmed that the lottery factor viz renders and behaves as expected on my end.

Copy link
Contributor

@JamesKunstle JamesKunstle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checks out locally and in review, nothing to add.

@JamesKunstle JamesKunstle merged commit c34915c into oss-aspen:dev Apr 10, 2024
5 checks passed
@cdolfi cdolfi deleted the lottery_line_update branch October 11, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: SCaLE -> OSS NA '24
Development

Successfully merging this pull request may close these issues.

Review other lottery factor viz
2 participants