Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Collection date to OSSF scorecard #729

Merged
merged 14 commits into from
Oct 11, 2024
Merged

Conversation

MoralCode
Copy link
Contributor

This is a mostly-there first-pass at tackling #720. It adds the date to the bottom of the box for the OSSF scorecard and repo info tiles.

The ossf scorecard one works, the repo info is having some issues that ill work on (ignore my broken fonts on my machine)

Screenshot_20241007_112324

TODO:

  • Add the date format to the information popup on each tile
  • detect the date format to use based on users browser locale settings (maybe)
  • debug and fix the repo info tile date
  • determine how to calculate the date for the repo info tile considering the data is coming from three different dataframes (should it just take the last date in the list? most recent? least recent? display a range of both?)

feedback welcome!

closes #720

@MoralCode
Copy link
Contributor Author

Ok i think i fixed the repo info one too (mostly by ignoring 2/3 of the dataframes)

@MoralCode MoralCode marked this pull request as ready for review October 7, 2024 16:56
@cdolfi
Copy link
Collaborator

cdolfi commented Oct 8, 2024

@MoralCode For repo_info it looks like its all coming from the same table, repo_info? If its more than one which ones are they?

@MoralCode
Copy link
Contributor Author

Yeah, for now its just taking all the last updated data from repo_info. I think the releases data frame could be empty and the other one probably requires me to change another query.

I wanted to get an answer on how you want to handle/combine the three sets of values (see my PR comment) before doing all that

@MoralCode MoralCode requested a review from cdolfi October 9, 2024 13:44
@MoralCode MoralCode mentioned this pull request Oct 9, 2024
@MoralCode MoralCode requested a review from cdolfi October 11, 2024 16:55
Copy link
Collaborator

@cdolfi cdolfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cdolfi cdolfi merged commit 434d1c4 into oss-aspen:dev Oct 11, 2024
5 checks passed
@MoralCode MoralCode deleted the collectiondate branch October 11, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Add "collected on" date to the repo overview page
2 participants