-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library Page Tests #229
Library Page Tests #229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ademDurakovic Good job! Try to add comments where necessary. Also, complete the remaining test cases, which include: wishing the user, rendering the notes, toggling the search bar, displaying the cross icon when the search bar is expanded, showing the LottieView animation when no search results are found, and implementing the account (top left side) component and the text component library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job writing these test cases, it adds to the project greatly. I left a few comments.
These tests have been added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ademDurakovic Good job, but you missed the test case for greeting the user. Please add that test case. Apart from this, everything looks good to me.
@rcAsironman That test has been added. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ademDurakovic lgtm;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
__![Uploading 411359105...]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love
Fixes #226
What was changed
The Library Page did not have any tests for it, this PR adds testing for this page. No UI changes were made.
Why was it changed
Previously, there were no tests for this page and that is bad practice. This PR boosts the applications reliability and overall monitoring.
How was it changed
A new file was created that is very similar to the rest of the UI testing ones. It uses TESTID in the library component code and then uses getByTestID() function to see if these components are even rendering.