Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Page Tests #229

Merged
merged 4 commits into from
Feb 9, 2025
Merged

Library Page Tests #229

merged 4 commits into from
Feb 9, 2025

Conversation

ademDurakovic
Copy link
Collaborator

Fixes #226

What was changed
The Library Page did not have any tests for it, this PR adds testing for this page. No UI changes were made.

Why was it changed
Previously, there were no tests for this page and that is bad practice. This PR boosts the applications reliability and overall monitoring.

How was it changed
A new file was created that is very similar to the rest of the UI testing ones. It uses TESTID in the library component code and then uses getByTestID() function to see if these components are even rendering.

Copy link
Collaborator

@rcAsironman rcAsironman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ademDurakovic Good job! Try to add comments where necessary. Also, complete the remaining test cases, which include: wishing the user, rendering the notes, toggling the search bar, displaying the cross icon when the search bar is expanded, showing the LottieView animation when no search results are found, and implementing the account (top left side) component and the text component library.

Copy link
Collaborator

@AmarHadzic AmarHadzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job writing these test cases, it adds to the project greatly. I left a few comments.

__tests__/Library.test.tsx Show resolved Hide resolved
__tests__/Library.test.tsx Show resolved Hide resolved
lib/screens/Library.tsx Show resolved Hide resolved
__tests__/Library.test.tsx Show resolved Hide resolved
__tests__/Library.test.tsx Show resolved Hide resolved
@ademDurakovic
Copy link
Collaborator Author

@ademDurakovic Good job! Try to add comments where necessary. Also, complete the remaining test cases, which include: wishing the user, rendering the notes, toggling the search bar, displaying the cross icon when the search bar is expanded, showing the LottieView animation when no search results are found, and implementing the account (top left side) component and the text component library.

These tests have been added.

Copy link
Collaborator

@rcAsironman rcAsironman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ademDurakovic Good job, but you missed the test case for greeting the user. Please add that test case. Apart from this, everything looks good to me.

@ademDurakovic
Copy link
Collaborator Author

@rcAsironman That test has been added. Thanks

Copy link
Collaborator

@rcAsironman rcAsironman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rcAsironman rcAsironman merged commit b8f280b into updateBottomTabBar Feb 9, 2025
Copy link

@Bravefriend82 Bravefriend82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love you

Copy link

@Bravefriend82 Bravefriend82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love

Copy link

@Bravefriend82 Bravefriend82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Copy link

@Bravefriend82 Bravefriend82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__![Uploading 411359105...]

Copy link

@Bravefriend82 Bravefriend82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants