fix(fastlane): use store-safe markup in app descriptions - #713
Merged
Conversation
Google Play renders neither <ul>/<li> nor <p>, while F-Droid turns every newline into <br>. Restrict the android descriptions to the subset both stores render: <b> headers, <i>, bullet chars and blank-line paragraphs. This also drops the <p> markup that was shipping to Play for fr-FR and de-DE. Sync the iOS descriptions with the android en-US content in plain text, as App Store Connect renders no markup at all, and add the missing cardwallet one. Refs #682 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Store descriptions are shared between renderers that do not support the same markup, so the files
now stick to the subset that works everywhere.
full_description.txt, both apps): section headers use<b>, bullets use•, sectionsare separated by blank lines. No
<ul>/<li>(Google Play does not render them) and no<p>(unsupported on both Play and F-Droid). This also removes the
<p>markup thatfr-FRandde-DEwere shipping to Play.
description.txt): now mirrors the androiden-UScontent, in plain text — App StoreConnect renders no markup at all. The
com.akylas.cardwalletiOS description did not exist and wasadded.
Why the subset: F-Droid supports
b/i/u/br/ul/ol/li/…and converts every newline to<br>, whileGoogle Play only supports
b/i/u/brplus entities. The intersection is<b>,<i>,<u>,<br>,literal bullet characters and blank-line paragraphs.
Testing
Metadata only — no app code touched, so no unit tests or
svelte-checkapply. Checked:<p>/<ul>/<li>/<h*>left in anyfull_description.txtdescription.txtActual store rendering can only be confirmed at the next release (
upload_store/deliverwithupload_metadata, and the next F-Droid/IzzyOnDroid build).Refs #682