Restructure storage of parameters and widgets in ParameterPanel
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoscinski
force-pushed
the
parameter-panel-code-api
branch
2 times, most recently
from
bf3243c to
8dd293d
Compare
Introduce `param_to_widget_map` to access the widgets in form of a dict
for more convenient handling.
To more robustly set parameter values the setter has been replaced by
the `update_params` method. The setter introduced behavior that is
unintuitive for python as it behaves like an update function while using
assign syntax.
Alternatively a design implementing methods `__{get,set}item__`,
`values` and `keys` was considered, but `keys` was clashing with the
trait variable of `Widget` which would have required a different naming.
This would have been more confusing.
```python
code_ex.params # returns parameter_panel
code_ex.params['x'] = 5 # works, updates the panel
code_ex.params['x']
code_ex.params.values() # works
code_ex.params.params_keys() # cannot be keys because it is already used by Widget
```
agoscinski
force-pushed
the
parameter-panel-code-api
branch
from
8dd293d to
9d8681d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
param_to_widget_mapto access the widgets in form of a dict for more convenient handling.To more robustly set parameter values the setter has been replaced by the
update_paramsmethod. The setter introduced behavior that is unintuitive for python as it behaves like an update function while using assign syntax.Alternatively a design implementing methods
__{get,set}item__,valuesandkeyswas considered, butkeyswas clashing with the trait variable ofWidgetwhich would have required a different naming. This would have been more confusing.📚 Documentation preview 📚: https://scicode-widgets--102.org.readthedocs.build/en/102/