Fixing unlinked traits in WCI due to invalid code_theme (Fix #53)
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding tests if invalid code theme returns error. Adding tests if widget view is updated on change of function_body trait.
agoscinski
force-pushed
the
fix/unlinked-traits
branch
from
b698665 to
92fe2c9
Compare
ceriottm
approved these changes
Jul 4, 2024
Increase waiting time and add sleep when a notebook is restarted. The notebook is sometimes run before jupyter has finished loading everything in the background.
agoscinski
force-pushed
the
fix/unlinked-traits
branch
from
116d4c1 to
82acb1c
Compare
The change in the last cell does not get active, since the widget has not been loaded fully.
agoscinski
force-pushed
the
fix/unlinked-traits
branch
from
82acb1c to
b1ba4cd
Compare
|
Sadly the lab-4 tests are a bit unstable. I think because you can run all cell with selenium before jupyter finished loading, which results in unexecuted cells, but what exactly is happening there is still unclear to me. Anyway I added some sleeps to make the tests also work in the CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #53
📚 Documentation preview 📚: https://scicode-widgets--54.org.readthedocs.build/en/54/