Update workflow policy to scan all branches for dangerous workflows #569 #622
+257
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all branches. Signed-off-by: Samuel Erb <[email protected]>
Signed-off-by: Samuel Erb <[email protected]>
Signed-off-by: Samuel Erb <[email protected]>
|
@raghavkaul can you review as well? Thanks. |
raghavkaul
approved these changes
Feb 11, 2025
| if err != nil { | ||
| return "", nil, err | ||
| } | ||
| return dir, repo, nil | ||
| } | ||
|
|
||
| // Function Close will close the scorecard clients. This cleans up the | ||
| // downloaded tarball. | ||
| func Close(fullRepo string) { |
There was a problem hiding this comment.
@jeffmendoza do we need to defer this func somewhere?
There was a problem hiding this comment.
Nice catch! I went through and defer scorecard.Close... all uses of the Get function.
pkg/policies/workflow/workflow.go
Outdated
| Msg(msg) | ||
| return &policydef.Result{ | ||
| Enabled: enabled, | ||
| Pass: true, |
There was a problem hiding this comment.
Suggested change
| Pass: true, | |
| Pass: false, |
pkg/policies/workflow/workflow.go
Outdated
| Msg(msg) | ||
| return &policydef.Result{ | ||
| Enabled: enabled, | ||
| Pass: true, |
There was a problem hiding this comment.
Suggested change
| Pass: true, | |
| Pass: false, |
pkg/policies/workflow/workflow.go
Outdated
| Msg(msg) | ||
| return &policydef.Result{ | ||
| Enabled: enabled, | ||
| Pass: true, |
There was a problem hiding this comment.
Suggested change
| Pass: true, | |
| Pass: false, |
serb-google
added a commit
to serb-google/allstar
that referenced
this pull request
Feb 28, 2025
|
Validated this still works as expected: |
Signed-off-by: Samuel Erb <[email protected]>
serb-google
force-pushed
the
workflows
branch
from
ac9b28f to
56c269f
Compare
|
Force-pushed to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #569 and introduces 2 changes:
Tested locally using https://github.com/serb-google/allstar, with a branch
insecure_testwhich contains a fake unsafe workflow rule. Verified this triggered the alert which included outputVulnerable Branch: refs/remotes/origin/insecure_test.This is my first contribution to this repo, please review carefully :)