ci: run build, link check, and linters on every PR - #41
Open
eddie-knight wants to merge 2 commits into
Open
eddie-knight wants to merge 2 commits into
eddie-knight wants to merge 2 commits into
Conversation
RuboCop's safe autocorrect over theme/_plugins (hash alignment, trailing commas, string-concat indentation, one unused block arg), plus three whitespace nits yamllint flagged in pages.yml and _config.yml. Rendered _site is byte-identical apart from the feed timestamp. Signed-off-by: Eddie Knight <knight@linux.com>
Adds .github/workflows/ci.yml with two jobs: - test: make test — jekyll build (catalog_pages.rb fails on duplicate ids and unresolvable references) followed by htmlproofer. - lint: make lint — RuboCop over theme/_plugins, yamllint over data/ and the workflows — plus actionlint on the workflow files themselves. Both reuse the Makefile so CI and local runs are the same command. Linter configs match the code that already exists rather than rewriting it: yamllint keeps line-length off (record descriptions are prose) and sequence indentation 'consistent' (data/ and the workflows differ); RuboCop keeps double quotes and drops Metrics, since splitting the validator to satisfy a length cop would scatter the guards. External link checking stays off — it would fail PRs on third-party downtime. Signed-off-by: Eddie Knight <knight@linux.com>
jmeridth
approved these changes
Sep 17, 2026
SecurityCRob
left a comment
SecurityCRob
left a comment
Contributor
There was a problem hiding this comment.
not being a developerologist..... this looks good to me, and i applaud the intention of the checking for each pr!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #40