feat!: adds unified package and reorganize schemas #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assisted-by: Composer (Cursor AI) Signed-off-by: Jennifer Power <[email protected]>
Add Architecture Decision Record (ADR-0001) documenting the decision to consolidate layer-based packages into a single unified gemara package. Includes README explaining the ADR format and when to create new ADRs. Assisted by: Composor (Cursor AI) Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
eddie-knight
reviewed
Dec 2, 2025
Collaborator
eddie-knight
left a comment
eddie-knight
left a comment
There was a problem hiding this comment.
This looks good to me! Left a couple minor comments.
Co-authored-by: Eddie Knight <[email protected]> Signed-off-by: Jennifer Power <[email protected]> Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
jpower432
force-pushed
the
add-common-types
branch
from
fcbe486 to
96d48b8
Compare
8 tasks
eddie-knight
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR accomplishes the following:
Schema Changes
Schema Changes Made
schemas/layer-1.cue) changesschemas/layer-2.cue) changesschemas/layer-3.cue) changesschemas/layer-4.cue) changesSchema Change Details
Schema changed were made to consolidate common types like
Metadata,Mapping, andContact.This is a breaking changes because the Metadata is updated to provide a common base for all top-level objects.
Testing
Related Issues
Closes #91
Reviewer Hints
In the second commit and an ADR documenting this decision and the tradeoffs was added