Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to remove code climate code smell #84

Open
ctsstc opened this issue Mar 15, 2019 · 0 comments · May be fixed by #92
Open

Try to remove code climate code smell #84

ctsstc opened this issue Mar 15, 2019 · 0 comments · May be fixed by #92
Assignees
@ctsstc

Comments

@ctsstc
Copy link
Member

ctsstc commented Mar 15, 2019

https://codeclimate.com/github/osu-cascades/hackbot/issues?category=complexity&engine_name%5B%5D=structure&engine_name%5B%5D=duplication

image
@ctsstc ctsstc self-assigned this Mar 15, 2019
ctsstc added a commit that referenced this issue Oct 4, 2019
@ctsstc
Methodize™ Code
7628f42 
Fixes #84

- Turn one method into many.
- Wow this thing really needs tests with all of it's crazy edge cases.
- This channel typing + type gaurds are a PITA + Crazy
- TODO: `execute` can instantiate an instance of this class
  - That sould clean up the redundant dependency injection going on
@ctsstc ctsstc mentioned this issue Oct 4, 2019
Open
@ctsstc ctsstc linked a pull request Oct 17, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctsstc ctsstc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Purge command osu-cascades/hackbot
1 participant
@ctsstc