Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Purge command #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor Purge command #92

wants to merge 1 commit into from

Conversation

ctsstc
Copy link
Member

@ctsstc ctsstc commented Oct 17, 2019 •
edited
Loading

Not sure why I never opened a PR for this several months ago. Maybe I never got around to testing it?

Changes

  • Flattens out code
  • Splits code into methods
  • Splits code into permissions helper
  • Adds a reusable helper directory
    • Adds permissions.ts

Fixes

@ctsstc
Refactor Purge command
abd7856 
Flattens out code
Splits code into methods
Splits code into permissions helper
@ctsstc
Copy link
Member Author

ctsstc commented Oct 17, 2019

Duplicate of #90
I think they both have some pros to them, so I need to determine if I can get them merged together 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Try to remove code climate code smell
1 participant
@ctsstc