Repository navigation
Conversation
The font and transition handlers buffer their property group and emit it when the declaration block is finalized. Longhands that the shorthand resets but that have no typed Property (font-kerning, font-feature-settings, font-variant-*, font-optical-sizing, font-variation-settings, transition-behavior, ...) fell through every handler and were pushed to the output immediately, so they ended up before a shorthand that was written before them, and the shorthand reset them again in the browser. The handlers now flush their buffered state when such a longhand arrives, the same way they already do for var()-valued longhands of their group, so source order relative to the shorthand is preserved.
… a name prefix A `font-*` / `transition-*` prefix also flushed on `-webkit-font-smoothing`, `font-synthesis-*` and Bootstrap 3's `-o-transition-*`, which the shorthands do not reset, and stopped the typed longhands around them from folding into a shorthand. Use the CSS Fonts 4 / CSS Transitions 2 list of reset sub-properties (font-variant and its longhands, font-width, font-size-adjust, font-kerning, font-feature-settings, font-language-override, font-optical-sizing, font-variation-settings, font-palette; transition-behavior), vendor prefix stripped.
|
Warning Review limit reached
This review includes 4 billable files and costs up to $1.00.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 24 minutes for your next included review. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (4)
Comment |
|
Status: closed. The fix landed on main in #47025 (7942008), in a smaller form than this branch. The rework that I announced was not pushed. What I checked on main after #47025, and the shapes that still differ, is in this comment. Reproduced originally on bun 1.4.3-canary with .b { font: 12px serif; font-kerning: none }
.c { transition: all 1s; transition-behavior: allow-discrete }Before #47025 the output put |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM — small, pattern-matched fix that mirrors the existing Property::Unparsed flush arm in both handlers.
What was reviewed:
- New
Property::Customarms inFontHandlerandTransitionHandler— both flush andreturn false, same shape as theUnparsedarm directly above. is_unknown_any_of:Custom(dashed) names short-circuit to false,Unknownnames go throughVendorPrefix::strip_from+strings::eql_any_case_insensitive_ascii— in-tree helpers, no hand-rolled matching.UNTYPED_FONT_SUBPROPERTIESlist checked against css-fonts-4 §4.7;font-synthesis-*/-webkit-font-smoothingexclusion is deliberate and covered by negative tests that assert folding still happens across them.- Test matrix covers before/after ordering,
!important, mixed case, vendor prefixes, and the negative cases (unrelated unknowns,-o-transition-*) that must still fold.
Extended reasoning...
Overview
The PR adds a Property::Custom match arm to FontHandler::handle_property (src/css/properties/font.rs) and TransitionHandler::handle_property (src/css/properties/transition.rs), plus a shared helper CustomPropertyName::is_unknown_any_of in custom.rs. When an untyped sub-property that the shorthand resets (font-kerning, font-variant-*, transition-behavior, etc.) is encountered, the handler flushes its buffered longhands so the untyped property stays on the side of the shorthand it was written on. A 15-entry UNTYPED_FONT_SUBPROPERTIES const lists the css-fonts-4 reset-only sub-properties. 22 new minify_test cases in test/js/bun/css/css.test.ts cover the fix.
Security risks
None. This is CSS minifier output ordering — no user-controlled paths, no allocation, no FFI, no auth/crypto surface. The new helper reads an arena-backed byte slice via the pre-existing as_str() accessor and does ASCII-case-insensitive comparison against a compile-time table.
Level of scrutiny
Low-to-medium. The change is ~50 lines of Rust across three files and follows the exact pattern of the Property::Unparsed arm that already exists one line above in both handlers (flush the buffer, return false so the property is emitted by the caller in place). The helper uses the in-tree bun_core::strings::eql_any_case_insensitive_ascii and VendorPrefix::strip_from rather than hand-rolling anything, satisfying the src/CLAUDE.md rule against raw substring matching. The property table is spec-cited and the comment explains the deliberate exclusions. No CODEOWNERS entry covers src/css/.
Other factors
Test coverage is thorough for a change this size: both orderings around the shorthand, !important, mixed-case names, vendor-prefixed variants, interleaved typed longhands that should still fold, and negative cases (-webkit-font-smoothing, font-synthesis-*, --font-x, -o-transition-*) that must not block folding. The PR description enumerates why animation and other shorthand handlers don't share this bug and scopes out the separate all: initial issue. The bug hunt ran to dry_streak with no findings and no ruled-out candidates. The PR timeline shows only two commits and no reviewer objections.
|
Updated 5:43 AM PT - Oct 8th, 2026
✅ @robobun, your commit 703fb6b7b7a31e818e3986628a8da617a648750d passed in 🧪 To try this PR locally: bunx bun-pr 41990That installs a local version of the PR into your bun-41990 --bun |
|
I worked on the same
The branch also has a 16-name by 4-shape |
|
Tested on current main: applied the two commits onto
I hit the same reordering in lightningcss and fixed |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| /// Whether this is an unknown (non-dashed) property whose name, with any | ||
| /// vendor prefix removed, is one of `names` (ASCII case-insensitive), e.g. | ||
| /// `font-kerning` or `-webkit-font-feature-settings`. Shorthand handlers use | ||
| /// this to recognize longhands of their group that have no typed `Property`. |
There was a problem hiding this comment.
If you need a paragraph-long comment to justify why the workaround is OK, the code is wrong — fix the code
| // Emit anything buffered before a sub-property that `font` resets, so | ||
| // it stays after a shorthand it was written after. |
There was a problem hiding this comment.
If you need a paragraph-long comment to justify why the workaround is OK, the code is wrong — fix the code
| /// Sub-properties that the `font` shorthand resets but that have no typed | ||
| /// `Property` variant, so they reach the handler as `Property::Custom`. | ||
| /// https://drafts.csswg.org/css-fonts-4/#font-prop | ||
| /// `font-synthesis-*` and `-webkit-font-smoothing` are not sub-properties of | ||
| /// `font` and are deliberately absent. |
There was a problem hiding this comment.
If you need a paragraph-long comment to justify why the workaround is OK, the code is wrong — fix the code
| // `transition-behavior` (css-transitions-2) has no typed `Property` | ||
| // variant but is reset by the `transition` shorthand, so anything | ||
| // buffered must be emitted before it to keep it after a shorthand | ||
| // it was written after. |
There was a problem hiding this comment.
If you need a paragraph-long comment to justify why the workaround is OK, the code is wrong — fix the code
| /// vendor prefix removed, is one of `names` (ASCII case-insensitive), e.g. | ||
| /// `font-kerning` or `-webkit-font-feature-settings`. Shorthand handlers use | ||
| /// this to recognize longhands of their group that have no typed `Property`. | ||
| pub(crate) fn is_unknown_any_of(&self, names: &[&[u8]]) -> bool { |
There was a problem hiding this comment.
🟣 pre-existing, not blocking: Pre-existing: users still get vendor-aliased longhands hoisted ahead of the buffered margin, padding, background and border shorthands that reset them. .a { margin: 0; -webkit-margin-start: 1em } minifies to -webkit-margin-start:1em;margin:0; Chromium and Safari alias that name to margin-inline-start, so margin: 0 now wins. The new flush exists only in the font and transition handlers. Fix: flush every buffering handler on the Unknown names its shorthand resets (-webkit-/-moz-margin-*, -webkit-padding-*, -webkit-border-*, -webkit-background-size, -webkit-logical-*), or state the exclusion in the PR. Same pattern at 4 sites (margin_padding.rs:730, background.rs:800, border.rs:1444, size.rs:762).
A small fix can ride a push you are already making; otherwise a short reply is enough.
Why this was flagged
A stylesheet writes a shorthand and then a vendor-prefixed alias of one of its longhands, e.g. .a { margin: 0; -webkit-margin-start: 1em }, and goes through DeclarationBlock::minify. PropertyId::from_name_and_prefix (src/css/properties/properties_generated.rs:1293) has no WEBKIT entry for margin-* or background-size, so the alias becomes Property::Custom with an Unknown name. The margin/padding handler (src/css/properties/margin_padding.rs:730) and background handler (src/css/properties/background.rs:800) return false without flushing, so the alias is pushed to hndlr.decls at src/css/declaration.rs:84-86 while the shorthand stays buffered until finalize. Output is -webkit-margin-start:1em;margin:0; Chromium and Safari treat -webkit-margin-start as an alias of margin-inline-start, so the later shorthand resets the authored value. This is exactly the reorder the PR fixes at src/css/properties/font.rs:946 and src/css/properties/transition.rs:344, but no other handler gets a Property::Custom arm. Base and merged output are identical for these inputs, so this is a pre-existing path the partial fix leaves failing.
Verification: PropertyId::from_name_and_prefix (src/css/properties/properties_generated.rs:1293) has no margin-start key, so -webkit-margin-start becomes Property::Custom. SizeHandler::handle_property returns false at margin_padding.rs:730 and BackgroundHandler at background.rs:800, so DeclarationBlock::minify pushes the Custom declaration into hndlr.decls (declaration.rs:80-87), emitted before the buffered shorthand at finalize(). The base branch already fails by the same route.
There was a problem hiding this comment.
#45825 covers this class. It adds alias: rows to the property name table for the 55 names that Blink, WebKit or Gecko alias to a property that a handler holds: -webkit-margin-start, -moz-padding-start, -webkit-background-size, -webkit-logical-width, -webkit-border-start, grid-gap and the others. Before such an alias prints, each handler writes what the alias can override.
One question there is open for a maintainer: do engine aliases belong in the name table, or in a name list in each handler as in this PR? font-width is in both.
There was a problem hiding this comment.
Correction to the comment above: #45825 now has rows for 54 names, and font-width is not one of them. A flush for it can print a font shorthand with a percentage stretch, so font-width stays with the font name list of this PR. The open question is the same: the name table, or a name list in each handler.
|
Findings from the review comments. There is no new push yet. The next push changes when the handlers flush, so hold the merge until then. Comment check (4 threads). The next push cuts each of those comments to one line.
Vendor aliases under other shorthands (thread on Two problems in the current diff, found while I measured.
A version that flushes only when a declared shorthand is buffered, and that does not merge a shorthand after one of these sub-properties, changes 0 of the 3,360 stylesheets and fixes both. I am comparing it with the other options before I push. |
|
The gate for the made-up It is a separate PR because the two changes fix different defects. The flush arm here fixes the order after a What #45459 adds to Proposed order:
Measured on 1,554 declaration orders in Chrome 153, source against output: main has 463 that compute differently, #45459 alone has 112. All 112 are a declared |
### What does this PR do? Consolidates the open pull requests on the CSS parser (`src/css`: parsing, minifying, lowering, printing, CSS modules) into one. 179 open pull requests were in scope. Each was judged by one rule: **the output must mean to a browser what the input meant.** Every claim was run through a build of `main`, a build with the change, lightningcss 1.33 and Chromium 156 (CSSOM, computed values, painted pixels for colors and gradients), and counted against 10,116 real stylesheets: the published CSS of about 190 popular npm packages, plus stylesheets from open source repositories. 107 land here, whole or in part, most of them cut down. The source diff is net negative. Of the 10,116, 9,509 are stylesheets that someone ships. The rest are test fixtures of other tools (521), Tailwind v4 source that needs its plugin (59) and SCSS, PostCSS or template source (27). | 9,509 shipped stylesheets | `main` | this branch | |---|---|---| | fail to build | 71 | 35 | | ... of those, valid CSS that Bun rejects | | 0 | | minified output reads differently in Chromium than the input | 552 | 2 | | CSS modules with a name that is referenced but not defined, or exported but not defined | 166 | 0 | | all 10,116 | `main` | this branch | |---|---|---| | fail to build | 192 | 141 | | minified output reads differently in Chromium than the input | 593 | 15 | | build on `main`, fail here | | 0 | | right on `main`, wrong here (minified, and at the default targets) | | 0 | | size of the minified output, no targets | 162.32 MB | 162.47 MB (+0.093%) | | size of the output at the default targets | 224.1 MB | 210.2 MB (-6.2%) | A syntax error is a build error, with one exception: the IE star hack `*zoom: 1` is skipped, because tachyons and handsontable ship it. The 35 shipped stylesheets that fail are invalid CSS: 28 have a selector that Chromium drops (semantic-ui-css, swiper, @ionic/core, Adobe Spectrum, xp.css), 2 an `@import` after other rules, and one each `@supports not X and Y`, a nested `@keyframes`, a stray comma, a selector list in `::slotted()`, `@media screen\0` (govuk-frontend). The 2 that read differently fold a `color-mix()` inside a gradient (see the known gaps). The growth of the minified output is rules and declarations that `main` deleted by mistake: 87 KB of rules, 45 KB of prefixed declarations that only browser targets can rule out. #### Popular CSS that `main` breaks today - normalize.css, modern-normalize, sanitize.css: `font-family: monospace, monospace` is collapsed to `monospace`, which changes the font size from 16px to 13px (#46662). - CKEditor 5, Tabler, Carbon, VitePress, Ionic, PatternFly, Excalidraw: a rule of custom properties is deleted as a "duplicate" of a later rule with the same selector and other custom properties. 37 stylesheets lose 1,681 custom properties (#33684). - Material Components, daisyUI, DocSearch, plyr: a `var()` size loses to its own fallback (#42101). - nextra, daisyUI, CKEditor: declarations written after a nested rule are moved above it (#45462). - antd 4, purecss, govuk-frontend: browser hacks in selector lists start to apply everywhere (#42100). - foundation-sites, flatpickr, 98.css, blueprintjs, scalar, react-datepicker: the build fails on valid CSS (#46756, #38552, #38534). tachyons, handsontable: it fails on the IE star hack (#46751). - nodejs.org, Mantine: a CSS module exports classes that no rule defines, because the `@apply` or `@mixin` in them is moved out of the rule (#46759). - hint.css and 42 more: `z-index: 1000001` and `1000000` become the same number (#46715). - Adobe Spectrum: `--version: 5.0.1` prints as `5.1`. - A quarter of all stylesheets: minified output has a stray space in `align-items: center` (#41993). #### Behavior changes to look at first 1. **`light-dark()` is kept as written at the default browser targets** (#42009). The lowered form `var(--buncss-light, a) var(--buncss-dark, b)` is invalid unless a compiled `color-scheme` covers the element: 184 of the 215 real stylesheets that get it never define the variable, so every browser drops the declaration. The docs section on the polyfill is removed. 2. **`border` is not built from longhands** (#42072): `border-width:0;border-style:solid;border-color:red` stays three declarations, because `border` also resets `border-image`. 305 real stylesheets grow by 30 KB in total; `bootstrap.min.css` by 113 bytes, 5 gzipped. No real stylesheet was found where the old merge shows, so this is the one to drop if size matters more. 14 existing expectations change. 3. **A CSS module no longer exports names that only occur inside `:global(...)`** (#45487). 73 real modules lose 202 export keys, all of them names that no rule has. `import { g }` or `composes: g` of such a name becomes a build error. 4. **Container names and `@counter-style` names stay global in a CSS module** (#45247 by @mikamikasuki). `main` hashes the `@container` name but not `container-name`, so a named query never matches. postcss-modules (Vite, css-loader, Next.js) keeps them global; lightningcss and esbuild hash both. Global keeps a container that is queried from another file or from JS working. 5. **Syntax errors are build errors, also two that `main` lets through**: a media query that stops short (`@media screen and {`, `@media not {`, `@import "a.css" screen and;`) and `@media (width <) foo {`. No stylesheet of the 10,116 has either. A condition that is valid by the grammar though no browser knows it, `( ... )` or `fn( ... )`, is kept as written (#46756): `(min-width:0\0)`, `(not(hover))`. 6. **Declarations after a nested rule stay where they were written**, as a nested declarations rule (#45462). Changes the output of 199 real stylesheets; in a fuzz of 2,850 nested programs compared by computed style, `main` was wrong in 1,056 and the pull request's code, before it was trimmed here, in none. 7. **`Bun.color`**: `color()` inputs are converted instead of returned as a string (`Bun.color("color(srgb 1 0 0)", "hex")` was `"color(srgb 1 0 0)"`); `currentColor`, system colors and `light-dark()` give `null` in the converting formats instead of the keyword as a string; a relative color or `color-mix()` outside sRGB is clipped, not gamut-mapped (`hsl(from oklch(100% .399 336.3) h s l)` is `#ff5bff`, was `#fff`). 8. The `:-moz-any()` and `:-webkit-any()` copies of rules with `:is()` are gone at the default targets (#45945, #42029). The `:-webkit-any()` copy outranked the original rule: `.title{color:blue} :is(h1,h2,h3){color:red}` painted red. 5.8% of all default-target output was the `:-moz-any()` copies. 9. `Property` grows from 216 to 224 bytes: `Url` stores its text as a slice so that two `url()` values can be compared (#46895). The pull request packed a pointer and a `u32` behind `unsafe` to avoid that. #### Not in this PR, needs a decision - **Raise the default browser targets (#40369) and add a `cssTarget` option (#40368).** Today: Chrome 80, Edge 80, Firefox 78, Safari 14, Opera 67, and no public way to change them. At Vite 8's floor the output of the 9,924 stylesheets is 15.3% smaller (3.9% gzipped). About a dozen fixes here only matter at today's floor, and code for older targets is unreachable without the option. - Vendor prefixes for `user-select`, `appearance`, `hyphens` and five more (#45814): 1,116 real stylesheets lack a prefix they need at the default targets. And for `backdrop-filter` (#44648): 173. - Clip instead of gamut-map in the sRGB fallback of a plain wide-gamut color: deletes about 90 lines, changes every pinned fallback hex. If the mapping stays, #44647 by @oddharsh makes it closer to what browsers paint (colors off by 2/255 or more: 168 to 110 of 3,170 real ones). #### Changes **Rules: duplicates, merging, nesting, fallbacks** - The `:-moz-any()` copy of every rule with `:is()` or `:not(a, b)` is gone: Firefox 78 has `:is()` (#45945). 1,164 real stylesheets - Keep declarations written after a nested rule in place with a nested declarations rule (#45462). 379 real stylesheets - With nesting compiled away, an unknown at-rule inside a style rule was moved out of it: `.wrapper{@apply flex}` printed a bare `@apply flex;` and the rule was gone, so a CSS module exported a class that no rule defines. It now stays in a block under the compiled selector. 72 real modules with Tailwind's `@apply`, 25 with Mantine's `@mixin` (#46759). 316 real stylesheets - Keep !important in the rules generated for logical properties and color-scheme (#38597). 311 real stylesheets - With browser targets, remove an earlier duplicate rule only when its declaration block is equal (#46861). 171 real stylesheets - Compare custom property names in `PropertyId` equality and importance in duplicate-rule detection (#33684). 40 real stylesheets - Keep same-condition @supports rules and empty named @layer blocks (#46733). 31 real stylesheets - Keep target-added vendor prefix passes on cloned and re-minified rules, and never print a bare `:full-screen` (#43339). 12 real stylesheets - Keep the selectors on rules added for color fallbacks and logical properties (#43240). 3 real stylesheets - A later declaration of a property drops the `@supports` color copies of the earlier one, which printed after the rule and won (#45560). 2 real stylesheets - Do not merge style rules in a stylesheet that holds `revert-rule` (#46953). 1 real stylesheets - `@import ... supports(-webkit-mask: none)` kept its prefix (#38589) **Properties and shorthands** - Print align-items:center without a stray space when no safe/unsafe keyword is given (#41993). 3,317 real stylesheets - Emit the physical longhands instead of the inset shorthand for targets without it (#38583). 1,452 real stylesheets - Keep the stops of an upward gradient as written, and drop a `50%` hint only at the midpoint (#46790). 104 real stylesheets - Emit unparsed border-block-* declarations when compiling logical borders (#38582). 89 real stylesheets - Keep repeated font families and dedupe only the inserted system-ui fallbacks (#46662). 88 real stylesheets - A `width` / `height` / `min-*` / `max-*` with `var()` or `env()` was printed before the plain fallback written above it, so the fallback won (#42101). 26 real stylesheets - Keep box-orient and box-direction when flex-direction or flex-flow follows (#45672). 16 real stylesheets - Write held prefixed background declarations at every flush (#46882). 6 real stylesheets - Derive equality for Size2D and BorderRadius, and keep every prefix in the border-radius handler (#45665). 2 real stylesheets - Print `none` instead of an empty border-image, mask-border or mask-box-image value (#45143). 2 real stylesheets - Keep font/transition sub-properties on the side of the shorthand they were written on (#41990). 2 real stylesheets - CSS-wide keywords are not names: `font:12px Arial;font-family:inherit` printed `font:12px inherit`, `color-scheme:inherit` and `color-scheme:auto` printed `normal`, `transition-property:unset` was folded into `transition` (#42022). 2 real stylesheets - Only fold font longhands into `font` when the rule declared a `font` (#45459) - Keep a font family name quoted when its identifiers do not read back as the same name (#46606) - Stop rewriting valid positions into ones browsers reject (#45197) - `border` is no longer built from longhands unless the rule also sets what `border` resets (`border-image`), and an author's `border-image` reset is no longer dropped. `transition` is likewise only written where the rule wrote one, because it resets `transition-behavior` (#42072) - `border; border-image: <gradient>; border-image-slice: 1` lost the gradient in every default build (#42018) - A prefixed `linear-gradient` keeps its direction, written or generated: the prefixed syntax names the starting side and measures angles differently (#46697) **At-rules** - Print @font-face format() keywords as strings (#37979). 439 real stylesheets - Print @supports `not` conditions without a leading space (#38559). 88 real stylesheets - Reset after the number token of a unicode-range (#45835). 33 real stylesheets - Keep `<general-enclosed>` media and container conditions as written (#46756). 24 real stylesheets - A strict range such as `(width < 768px)` lowered for old targets still matched at exactly 768px. The step is now `.02px`. The `not all and` form for other units is not taken (#46806). 18 real stylesheets - Keep scanning an @supports condition after a nested block (#38552). 9 real stylesheets - Every `@counter-style name` printed as `@counter-stylename`, which browsers drop (also #46692). In a CSS module the name now stays global, like the `list-style` that refers to it (#33679). 9 real stylesheets - Keep a keyframe whose block has an invalid item (#46288). 2 real stylesheets - Read an @Property initial-value on the stylesheet's parser, keep an unmatched value as written (#45806). 2 real stylesheets - `@media {}` is `all`. A media query that stops after `and`, `or` or `not` (`@media screen and {`) is a build error; `main` printed `not all` or dropped the condition, silently. The `@layer` and type selector parts are not taken (#46869). 2 real stylesheets - Accept a name-only `@container` and a `style()` feature with no value (#46689). 1 real stylesheets - Parse `<timeline-range-name> <percentage>` keyframe selectors (#45652) - Allow `or` inside parentheses after a media type (#45088) - Print the `=` comparison in media and container queries as `=` (#45071) - Parse the @font-palette-values font-family descriptor as a list of family names (#45484) **Selectors** - Never wrap a selector list in :is() (#46787). 414 real stylesheets - Stop emitting :-webkit-any() copies of :is() that outrank the original rule (#42029). 373 real stylesheets - With browser targets, a selector list with a vendor-prefixed member was split, which revives hacks that rely on other engines dropping the whole list: `.s *::-ms-backdrop,.s{flex:auto}` applied everywhere. Rewritten; the list is printed as written (#42100). 42 real stylesheets - Print the vendor prefix on downleveled :any-link, :read-only, :read-write, :placeholder-shown and :autofill (#42131). 12 real stylesheets - Fix nesting lowering of a `&` that does not lead its selector (#43047). 8 real stylesheets - `@scope`: `&` and implicit selectors compile to `:where(:scope)`, relative selectors and bare declarations parse (#43165). 7 real stylesheets - Only reject bare :global / :local pseudo-classes in CSS modules (#38534). 5 real stylesheets - Stop truncating `@scope to (...)` and stop replacing `&` in the scope-end selector (#43146). 2 real stylesheets - `[xl|href$=".pdf"]` lost its namespace prefix (#45159). 2 real stylesheets - Match An+B keywords exactly and take only `+` as the leading sign (#42953). 1 real stylesheets - Parse ::details-content and ::picker() like ::part() (#45504). 1 real stylesheets - Parse :window-inactive as an ordinary pseudo-class, and accept it after ::selection (#45815) - Print :nth-col(1) and :nth-last-col(1) in functional form (#41575) - `li::before::marker` failed the build (#45810) - `&` inside `:nth-child(... of S)` is resolved when nesting is compiled away. The second selector serializer (326 lines) is deleted (#43024) **Colors and `Bun.color`** - Keep light-dark() as written under the default browser targets (#42009). 227 real stylesheets - Number and percentage channels parse in `lab()`, `lch()`, `oklab()`, `oklch()`, `hsl()` and `hwb()`; the hue of `lch` / `oklch` is no longer scaled by alpha (#45084). 130 real stylesheets - `Bun.color` returns `null` for `currentColor`, system colors and `light-dark()` in the converting formats, instead of the CSS keyword as a string (#33047). 130 real stylesheets - Relative colors: channel keywords are on the scale of their function (`rgb(from #369 calc(r + 10) g b)`), the origin's alpha is kept, a relative color kept as written gets no `@supports` copies, and a result outside sRGB is not folded (#45362). 31 real stylesheets - Keep rotate: 0deg out of none, and keep the origin alpha in relative colors (#38486). 13 real stylesheets - Compute the D50 reference white in f32 so greys convert to lab(l 0 0) like lightningcss (#38535). 7 real stylesheets - Return a missing hue for a grey from conversions into lch, oklch, hsl and hwb (#45201). 5 real stylesheets - Fix color(a98-rgb), srgb-linear relative colors and color-mix(in xyz-d50) (#38487). 4 real stylesheets - Match named colors without regard to ASCII case (#45092). 3 real stylesheets - Fold min(), max() and clamp() over plain numbers (#39515) - `calc(l - .08)` in a percentage channel of a relative color became NaN and printed `#000` (also #45970) (#45971) - Bun.color: convert color() inputs instead of returning them as a CSS string (#38488) - A `color-mix(in srgb, ...)` result outside sRGB prints `color(srgb ...)` instead of a gamut-mapped hex (#39269) **`calc()` and numbers** - Rounding to 6 significant digits ate into the integer part: `z-index:2147483647` became `2147480000`, `max-width:9999999px` became `10000000px`, `--x:1234567.5` became `1234570`. It now only cuts a fraction short: a value kept as tokens prints its source text, a typed value prints every integer digit and at least one digit of the fraction (#46715). 43 real stylesheets - A number without a unit is no longer repaired into `px` (`height:1.5715` is dropped by a standards-mode browser, so it prints as written), `calc(-1 * 0)` is not a length, and on a property of the range [0,∞] (sizes, border radii, padding, border and outline widths, gap, `flex-basis`, `font-size`) a `calc()` that folds below zero prints `0` instead of an invalid negative literal, and a negative literal no longer replaces the valid declaration before it (`width:10px;width:-5px` printed `width:-5px`) (#42104). 24 real stylesheets - Print numbers from the f32's shortest digits, not its f64 expansion (#38565). 17 real stylesheets - Print negative numbers below 1 with a single minus sign (#38516) - Keep math functions over two different length units as written (#38489) - Fold rem() with a truncated quotient, so it keeps the sign of the dividend (#32286) - A one-argument `min()` / `max()` around a sum printed without any function (`width:100% - 20px`) (#46145) - `round()` breaks ties upward and handles a negative step as browsers do (#45249) **CSS modules** - A CSS module exports its `@keyframes` names (`styles.spin`). Hashing is unchanged (#46720). 145 real stylesheets - A name inside `:global(...)` prints plain but was exported as `name_<hash>`, a class no rule has (also #38573) (#45487). 90 real stylesheets - Keep container names global in CSS modules (#45247). 6 real stylesheets - Tag the keyframes name when an `animation` value falls back to raw tokens (#46034). 6 real stylesheets - In a plain stylesheet `composes: a from "./b.css"` was treated as an import: the file was inlined and an absolute path printed (#45961). 4 real stylesheets - Drop a rejected composes instead of failing the file at print time (#38538). 1 real stylesheets - Keep every rule's custom properties for the composes conflict check (#38523) - Keep composes working after a nested rule in the same block (#38520) - `IdentOrRef::hash` read 2 of 16 bytes, so in release builds every class of a module hashed alike (#30784) **Tokens, `url()`, diagnostics** - The block skip stack no longer allocates on every block exit (#39533) - Report the diagnostic's line without its line breaks in position.lineText (#38342). 192 real stylesheets - Compare `url()` values by their text (#46895). 26 real stylesheets - Values kept as tokens keep the blanks they were written with instead of having them re-invented at print time: `attr(x type(<number>))` printed `type(< number> )`, which browsers drop. Minified output still drops the blanks that cannot matter (#45577). 19 real stylesheets - The IE star hack (`*zoom:1`) failed the whole build. The declaration is skipped, as every browser does. It is the one syntax error that builds: tachyons, handsontable and jasmine ship it (#46751). 8 real stylesheets - The path of a copied asset spliced into `url()` is always quoted, so a file name with a space or a parenthesis cannot end the `url()` (#41557). 7 real stylesheets - Move the skip loop of parse_until_before out of the generic body (#39520) - Remove dead code from bun_css: the unused `impl Default for Property` (#45618) - Default the at-rule and qualified-rule parser traits, drop the url_to_css shim (#31999) **Speed** Four inputs that took quadratic or exponential time, or produced output out of proportion, are now linear, with no new limit and no extra pass (#31639, #42243, #38531, #43421). **Tests only** - `css-fuzz.test.ts` never ran in CI and timed out on debug builds; it is a deterministic table now (#38500) - `nth-anplusb-ident.test.ts` counts heaps in a child process (#46331) - `color.test.ts` checks the ansi-16 sweep with one `expect()` (#42824) - Not CSS, but it failed this PR's CI and fails on `main` too: `ws-proxy.test.ts` on Windows, "a message sent during a TLS renegotiation arrives after it". The helper server now renegotiates from the callback of the frame's write (#46170) **No pull request covered these** - `--v: 5.0.1` printed as `5.1`, `--w: 1.0.0` as `10`, `--x: 1+2` as `12`, `2n+1` as `2n1`: a number token that touches another keeps its source text. - `color-scheme: auto` printed as `normal`, and `color-scheme: dark light` as `light dark`. - A bare `:global` or `:local` in a CSS module sets the scope of the names after it, up to the end of the selector, as in css-loader. It was a build error. - The scrollbar states (`a:horizontal`, `::-webkit-scrollbar{&:horizontal{}}`) are valid in a plain compound, as in WebKit and Blink. - Without browser targets, `-webkit-box-align`, `-ms-flex-align` and the like were dropped next to their standard form (flatpickr, foundation-sites, materialize-css: 28 stylesheets), and `-webkit-fill-available` before `-moz-available` (beercss). - `(-o-min-device-pixel-ratio: 2/1)` printed as `2`. - `sin()`, `cos()` and `tan()` are exact at multiples of 90deg: `calc(100px * cos(90deg))` printed `-.00000437114px`. - A `display-p3` color at targets that have P3 but not the other `color()` spaces (Safari 10.1 to 14) got itself as a fallback. - `width: rem(-18px, 5px)` folds to a negative literal once `rem()` is right; it prints `0`. - Consecutive nested declarations rules, which arise when same-query `@media` blocks in one rule merge, are folded into one and count against the existing selector expansion limit as the `&{}` rules they replace did. #### Known and not fixed here - Four longhands are still folded into a `transition` the author did not write where the targets add a prefixed copy of a property (`mask-image` at Chrome 80): only the shorthand gives the copy its own times. - A later `background`, `box-shadow` or `border-*` declaration still loses to the `@supports` copy of an earlier `var()` value of the same property with a wide-gamut color. Same on `main`; #45560 is taken for the properties of the fallback handler and for unparsed values only. - A merged rule prints the unprefixed name in the passes of the rule it absorbed: `.d::-webkit-input-placeholder{}.d::-moz-placeholder{}` prints `::placeholder` for the second (#42106, not taken: it breaks the merge of prefix-equivalent rules). - The `border`, `outline` and `font` shorthands, `line-height`, `scroll-padding`, `background-size` and a few more still print a `calc()` that folds below zero as a negative literal. No real stylesheet has one. - `all` is not a property Bun knows, so `a{margin-top:1px;all:unset}` prints `all` first. Same on `main`. - A selector kept as raw tokens loses the blank before `*` when minified: `--sel: .dark *` prints `.dark*`. Same on `main`. - `width:calc(0% + 12px)` folds to `12px`, which lays out differently in a table cell. Same on `main`. - The `:dir()` / `:lang()` rules of a lowered logical property print before the nested rules of their rule, so a logical declaration written after a nested rule of equal specificity still loses to it. Same on `main`. - A fraction is still rounded to 6 significant digits (`12345.678` prints `12345.7`, `33.3333333333%` prints `33.3333%`). Keeping every digit would add up to 282 KB over the corpus. - `@keyframes "quoted"` is hashed in a module but not exported. - In a module, a keyframes name inside a `var()` fallback is not hashed: `animation: var(--enter, fade 1s)`. Same on `main`. - A `color-mix()` or relative color folded to a hex inside a gradient changes the interpolation from Oklab to sRGB (VS Code, clawhub). Printing `color(srgb ..)` instead needs a fallback for `mask-image`, `list-style-image` and custom properties at the default targets, which have none. - A comma list in `@container` still fails the build. - After a bare `:global`, names that are hashed at print time (`::view-transition-old(foo)`) are still hashed; inside `:global(...)` they are not. #### Pull requests in scope that do not land here - Duplicates of a pull request that lands here: #36961 (of #37979), #38478 (of #46662), #38480 (of #46733), #38482 (of #46715), #38491 (of #38500), #38508 (of #45201), #38513 (of #45362), #38573 (of #45487), #38640 (of #38500), #45525 (of #45247), #45589 (of #46756), #45970 (of #45971) - Already fixed on `main`: #38674 - Right, but for input nobody writes (0 of 10,116 stylesheets, and not new syntax): #31916, #38526, #38592, #39349, #41139, #41801, #42042, #42484, #43078, #45604, #45908, #46086, #46221, #46224, #46273, #46694, #46707, #46737, #46755, #46816, #46870, #46934 - Right or harmless, but not worth their code, their bigger output or the behavior they change: #30905, #31924, #33332, #34426, #36225, #38006, #38512, #38547, #38551, #38561, #38572, #38576, #38607, #38623, #38667, #38692, #42106, #42912, #42918, #43407, #43434, #44700, #45442, #45546, #45747, #45759, #45825, #45946, #46061, #46127, #46206 - Need a decision (see above), stay open: #40368, #40369, #44647, #44648, #45814 - Stays open: #45787 Out of scope: CSS linking and chunking in the bundler, the dev server, docs-only pull requests, and repository-wide sweeps that touch `src/css` in passing. Thanks to @mikamikasuki (#45247), @alii (#39520, #31999) and @oddharsh, whose measurements on #40369 and #41990 were used. Fixes #16727. Fixes #24770. Fixes #30772. Fixes #44704. Fixes #45089. Fixes #45237. Fixes #46872. ### How did you verify your code works? - The 35 CSS test files pass on a debug build, also with `FORCE_COLOR=1`. 600+ of the tests in this branch fail on a build of `main`. An earlier head of this branch passed all 179 CI jobs that ran. - The reproduction of each issue listed above was run on `main` (wrong) and on this branch (right). - Differential run over the 10,116 stylesheets, `main` against this branch, minified without targets and through `Bun.build` at the default targets: no stylesheet that builds on `main` fails; Chromium 156 compares the output with the input rule by rule (CSSOM, then computed values on a sized element in a standards-mode document, colors as painted pixels in sRGB and P3). The comparison has 195 control pairs that must read equal or different. For stylesheets that read differently on both builds, mostly because of lowering, the sets of differences were compared; the three new ones are two minifier fixtures that are wrong on both and one comparison artifact. - CSS modules are checked for consistency instead, since hashed names defeat the comparison: every reference points at a name the output defines, every export exists. - `Bun.color`: 59 inputs in 13 formats on both builds; every changed cell was read.
|
Thanks. I checked #47025 on a debug build of main (7942008), source against output in Chrome 153. The reported shapes are right now: Four shapes still compute a different style at the default targets. None of them was in the 3,360 real stylesheets that I measured, so this is for the record.
A fifth shape only shows in a browser without The first two rows have one cause. The flush at The rework that I announced here was not pushed, and I will not open a PR for it. It held these declarations in the two handlers and fixed all five shapes, but it was about 380 lines of source. If you want the |
Problem
bun buildmoves reset-only longhands written after their shorthand to before it..b { font: 12px serif; font-kerning: none }becomesfont-kerning: none; font: 12px serif..c { transition: all 1s; transition-behavior: allow-discrete }becomestransition-behavior: allow-discrete; transition: all 1s. The browser then resets the longhand again (font-kerningnone->autoin Chromium 148).FontHandler::handle_property(src/css/properties/font.rs:906) andTransitionHandler::handle_property(src/css/properties/transition.rs:200) buffer their group untilfinalize().font-kerning,transition-behaviorand the rest have no typedPropertyvariant. They parse asProperty::Customwith anUnknownname, no handler claims them, and they go to the output at once, ahead of the buffered shorthand.Fix
Property::Customarm. When the name (vendor prefix stripped, case-insensitive) is a sub-property the shorthand resets, the handler flushes its buffer and returnsfalse, so the property lands right after it. TheProperty::Unparsedarm already does this forvar()values.UNTYPED_FONT_SUBPROPERTIESinfont.rs, andtransition-behavior). Names the shorthands do not reset (-webkit-font-smoothing,font-synthesis-*, Bootstrap 3's-o-transition-*) still let the typed longhands around them fold.test/js/bun/css/css.test.ts(22 new cases, 16 fail on stock bun). Also all oftest/js/bun/css/,test/bundler/esbuild/css.test.ts, and a byte compare of 17 real-world stylesheets (no change).Background
DeclarationBlock::minify(src/css/declaration.rs) runs each declaration through a chain of per-shorthand handlers. A handler that claims a property buffers it. Unclaimed properties go straight to the output.finalize()flushes the handlers last. So a handler must own every property its shorthand interacts with.fontfirst resets all its sub-properties, also the ones it cannot set. CSS Transitions 2 makestransitionresettransition-behavior.Notes
fontlist:font-variant,font-variant-ligatures,-alternates,-numeric,-east-asian,-position,-emoji,font-width,font-size-adjust,font-kerning,font-feature-settings,font-language-override,font-optical-sizing,font-variation-settings,font-palette. The typed members of the group (font-family,font-size,font-style,font-weight,font-stretch,line-height,font-variant-caps) never reach this arm.test/js/bun/css/files/(bootstrap 4, bulma, foundation, tailwind, uikit, ...) plus Bootstrap 3.3.5 and 3.4.1.font-*properties that follow afontshorthand parcel-bundler/lightningcss#1209 (open, unmerged) flushes on anyfont-*name. A first revision here did the same. Afont-*/transition-*prefix also fires on-webkit-font-smoothing,font-synthesisand-o-transition-*, which are not reset by the shorthands, and it stoppedfont: 14px Arial; -webkit-font-smoothing: antialiased; line-height: 1.4from folding tofont:14px/1.4 Arialand Bootstrap 3's prefixed transition longhands from folding totransition:opacity 1s linear. The explicit list avoids that.none->auto, font-size-adjust0.5->none, font-optical-sizingnone->auto, font-variation-settings"wght" 700->normal, font-feature-settings"liga" 0->normal, transition-behaviorallow-discrete->normal.font-variant: normalafterfont-variant-caps: small-caps, andfont-width: normalafterfont-stretch: condensed, were reordered the same way and are covered by the same arm.-webkit-font-feature-settings/-moz-font-feature-settings, which those engines alias to the unprefixed property, also stay afterfont.Property::Unparsedis a known property whose value did not parse (usuallyvar()).Property::CustomwithCustomPropertyName::Unknownis a name the crate has no variant for.font-familyas emitted for the block, so a laterfont: ... system-uiin the same rule does not get the system-ui fallback list again. That is the existing behaviour of theProperty::Unparsedpath (font-family: x; font-size: var(--s); font: 16px system-uidoes the same on stock bun).animation-composition/animation-timelineafteranimationwere already kept in order: bun has no animation handler, so nothing is buffered there.all: initialwritten after handler-owned properties (font,margin, ...) is emitted before them, because lightningcss'sDeclarationHandler::handle_allwas never ported. That is a separate change of about 40 lines confined tosrc/css/declaration.rsand does not interact with these arms. It is being handled on its own.fontlonghands appear in one rule they are folded into afontshorthand, even if a reset-only longhand precedes them or another rule sets one. That is a pre-existing lightningcss trade-off of synthesizing the shorthand at all.-webkit-font-smoothing,font-synthesis,-o-transition-*; vague wording about theallfollow-up), 4 addressed.[human-review] gate passed · iteration 0 · 4 files touched
fails on main (without fix)
passes on PR (with fix)
diff hotspot
gate history · 1 passed · 0 rejected · iteration 0
evidence per changed file