-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added some jest-extended
methods
#9741
feat: Added some jest-extended
methods
#9741
Conversation
jest-extended
methods
Thanks for working on this PR! We'll take a look at it soon, we're currently busy getting fixes for Windows in Bun v1.1.1. |
@dylan-conway can you take a look and review? |
❌ @nithinkjoy-tech, your commit has failing tests :( 💪 1 failing tests Darwin AARCH64
🪟💻 2 failing tests Windows x64 baseline
🪟💻 2 failing tests Windows x64
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry review took so long. I think overall this is good. I left a few comments for changes to error messages and checking if expected
is an array
Co-authored-by: Dylan Conway <[email protected]>
Co-authored-by: Dylan Conway <[email protected]>
Co-authored-by: Dylan Conway <[email protected]>
Co-authored-by: Dylan Conway <[email protected]>
@dylan-conway Thank you for taking the time to review my code! I have updated the code based on your feedback. Can you please have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
jest-extended
methodsjest-extended
methods
What does this PR do?
Add
toContainAllKeys
toContainValue
toContainValues
toContainAllValues
toContainAnyValues
from #1825How did you verify your code works?
bun-debug test test-file-name.test
)