Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added some jest-extended methods #9741

Conversation

nithinkjoy-tech
Copy link
Contributor

What does this PR do?

Add toContainAllKeys toContainValue toContainValues toContainAllValues toContainAnyValues from #1825

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

  • Wrote automated test cases
  • I included a test for the new code, or an existing test covers it
  • I wrote TypeScript/JavaScript tests and they pass locally (bun-debug test test-file-name.test)

@nithinkjoy-tech nithinkjoy-tech changed the title feat: Implemented some jest extended methods feat: Implemented some jest-extended methods Apr 3, 2024
@Electroid
Copy link
Contributor

Thanks for working on this PR! We'll take a look at it soon, we're currently busy getting fixes for Windows in Bun v1.1.1.

@Jarred-Sumner
Copy link
Collaborator

@dylan-conway can you take a look and review?

Copy link
Contributor

github-actions bot commented Jun 1, 2024

@nithinkjoy-tech, your commit has failing tests :(

💪 1 failing tests Darwin AARCH64

  • test/cli/install/bun-run.test.ts 1 failing

🪟💻 2 failing tests Windows x64 baseline

  • test/cli/install/bunx.test.ts 1 failing
  • test/integration/next-pages/test/dev-server.test.ts 1 failing

🪟💻 2 failing tests Windows x64

  • test/cli/install/bunx.test.ts 1 failing
  • test/integration/next-pages/test/next-build.test.ts 1 failing

View logs

Copy link
Member

@dylan-conway dylan-conway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry review took so long. I think overall this is good. I left a few comments for changes to error messages and checking if expected is an array

@nithinkjoy-tech
Copy link
Contributor Author

@dylan-conway Thank you for taking the time to review my code! I have updated the code based on your feedback. Can you please have a look.

Copy link
Member

@dylan-conway dylan-conway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dylan-conway dylan-conway merged commit 80e4e60 into oven-sh:main Jun 9, 2024
50 of 53 checks passed
@nithinkjoy-tech nithinkjoy-tech changed the title feat: Implemented some jest-extended methods feat: Added some jest-extended methods Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants