Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

379 log graph ql errors #417

Closed
wants to merge 4 commits into from

Conversation

mauriau
Copy link

@mauriau mauriau commented Nov 13, 2018

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Documented? no
Fixed tickets #379
License MIT

Just add a logger to catch errors from graphQl results

I thinks, we can closed my old PR #396, because, of the link to our repository is lost

mauriau wants to merge 1 commit into overblog:master from *unknown repository* 

@mauriau mauriau force-pushed the 379-log-graphQL-errors branch 2 times, most recently from 62c21be to a11b1a8 Compare November 20, 2018 10:15
@mauriau mauriau force-pushed the 379-log-graphQL-errors branch from a11b1a8 to 9bccaa2 Compare November 20, 2018 10:24
Copy link
Member

@mcg-web mcg-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change look good to me, thanks for this contribution! It is missing some documentation ready to merge. Can you provide this please?

@Vincz
Copy link
Collaborator

Vincz commented Jan 13, 2019

Hey guys ! Any update about this PR? Just the doc is missing?

@mcg-web
Copy link
Member

mcg-web commented Oct 1, 2019

This PR seems to be inactive for quite some time now, so I've closed it. If you feel this PR deserves some attention feel free to reopen it.

@mcg-web mcg-web closed this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants