Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made it possible for totalCount to be a promise #777

Closed
wants to merge 404 commits into from
Closed

Made it possible for totalCount to be a promise #777

wants to merge 404 commits into from

Conversation

rsolyanik
Copy link
Contributor

An error Object of class GraphQL\\Executor\\Promise\\Promise could not be converted to int occurs when trying to return a promise to totalCount.

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? no
Fixed tickets #286
License MIT

murtukov and others added 30 commits March 6, 2020 14:51
@murtukov
Update index.md
0d050ae 
Update the versions requirements table
@mcg-web
Merge pull request #660 from overblog/murtukov-patch-1
21ca2d2 
Update index.md
@mcg-web
Merge branch '0.12' into 0.13
b7704b8
@mcg-web
Merge branch '0.13'
3496e31
@mcg-web
Merge branch '0.12' into 0.13
a8b6659
@mcg-web
Merge branch '0.13'
4cdaa0d
@mcg-web
Revert "Fix BC"
13b874f 
This reverts commit d3497c1.
@mcg-web
Fix var name
7155466
@mcg-web
Merge branch '0.13'
5e7b8d5
@murtukov
Update README.md
977051a
@mcg-web
Merge pull request #665 from overblog/murtukov-patch-2
69d7e5d 
Update README.md
@murtukov
Update README.md
12bb9f0 
Add Telegram support group link
@murtukov
Update README.md
985eae1
@mcg-web
Merge pull request #667 from overblog/murtukov-patch-2
3e3195d 
Update README.md
@mathroc
fix typo in relay paginator helper documentation
7cde2e4
@murtukov
Merge pull request #670 from mathroc/patch-1
ad32cc0 
fix typo in relay paginator helper documentation
@IceShack
Add private property annotations from inherited classes
c493d99
@IceShack
Merge branch '0.13' into feature/inheritPrivateProperties0.12
065b08b
@IceShack
Added missing trailing comma
4679b3a
@ste93cry
Make the encoder for the cursors of the edges of a connection customi…
9a94043 
…zable
@ste93cry
Add missing entry to the UPGRADE-1.0.md file
7acd6a3
@ste93cry
Revert the default cursor encoder to base64 (not url-safe)
7458004
@mcg-web
Merge pull request #678 from ste93cry/feature/custom-connection-curso…
313f199 
…r-encoder

Make the encoder for the cursors of the edges of a connection customizable
@murtukov
Update index.md
aef0094 
Fix typo
@murtukov
Merge pull request #681 from overblog/murtukov-patch-1
ebaed75 
Update index.md
@Vincz
Merge pull request #675 from IceShack/feature/inheritPrivatePropertie…
6433464 
…s0.12

Add private property annotations from inherited classes
@murtukov
Fix ValidationNode.php
8dcf1fb 
Same fix as #686 but preserving older PHP versions
@mcg-web
Merge pull request #687 from overblog/murtukov-patch-1
ea0e1ab 
Fix ValidationNode.php
@mcg-web
Merge branch '0.12' into 0.13
fba5f10
@mcg-web
Fix 0.13 travis build
aeada63
mcg-web and others added 29 commits October 24, 2020 17:10
@mcg-web
Merge pull request #764 from overblog/murtukov-patch-2
3fedbdf 
Update links in README.md
@mcg-web
Merge pull request #765 from overblog/murtukov-patch-3
e7bea0c 
Update index.md
@murtukov
Refactor code according to the new PHPStan version
b5f2a3a
@murtukov
Merge pull request #769 from murtukov/fix/phpstan
c6d67a4 
Fix/phpstan
@murtukov
Refactor TypeBuilder and resolve some todos
f870649 
- Add extended PHPDocs with code examples
- Disable PHP-CS-Fixer rule to add unnecessary dots
- Create static method to check expression prefix
@murtukov
Merge branch 'master' into refactor/type_builder
bd7d021
@murtukov
Fix typos
08d8711
@murtukov
Use arrow function without arguments if no expression is used
19bae10
@murtukov
Fix phpstan errors introduced in 0.12.53
fbf0846
@murtukov
Merge pull request #770 from murtukov/refactor/type_builder
55c14a3 
Refactor TypeBuilder and resolve some todos
@murtukov
Remove config pass
714de23
@murtukov
Merge branch 'master' into refactor/remove-unnecessary-config-pass
1e33454
@murtukov
Remove LazyConfig calls from generated types
493b8ab
@murtukov
Remove unnecessary passes of $globalVariables
22afbb2
@murtukov
Don't return $lazyConfig back from methods
3c951f6
@murtukov
Get rid of LazyConfig.php
88c87ae
@murtukov
Reduce unnecessary calls
01cfbe2
@murtukov
Add quotes
5593464
@mcg-web
Merge pull request #771 from murtukov/refactor/remove-unnecessary-con…
079cdae 
…fig-pass

Remove compiler pass
@murtukov
Merge branch 'master' into refactor/remove-lazyconfig
50745f5
@murtukov
Update method description and perform code quality
e18c116
@murtukov
Pass arrays to config processors by value
bc1eb48
@mcg-web
Merge pull request #772 from murtukov/refactor/remove-lazyconfig
8d1d870 
Optimize config processing
@murtukov
Update index.md
4ca23aa 
- Fix example errors
- Clarify text
@murtukov
Merge pull request #773 from overblog/murtukov-patch-2
1bcf917 
Update index.md
@murtukov
Fix profiler bug
1625218
@murtukov
Merge pull request #774 from murtukov/fix/profiler
6f78dc3 
Fix Profiler bug
Made it possible for totalCount to be a promise (for using with data …
eb3bad5 
…loader)
@rsolyanik
Merge branch 'master' into 0.12
1a042f5
@rsolyanik rsolyanik closed this Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.