-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditional Restrictions - Add conditional restriction logic to field meta schemas and implement validation logic #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are breaking changes to the meta schema that need to be published as a major release. A document should be added to the repo describing these changes.
- performs code list and regex reference replacement recursively through conditional restrictions - performs reference replacement recursively through meta objects - applies conditional restriction checks when resolving restriction rules for each field - WIP: still requires many tests
- Generic conditional restriction function was removed because it could not be interpretted by the json schema generator - Although there is repeated code, directly writing the typed conditional restriction type schemas is easier to parse and hopefully maintain. They have their types enforced by a generic type even if the schema itself is not generated through a function.
leoraba
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Introduces Conditional Restrictions to the Lectern meta schema. All field types can now optionally contain conditions for applying restrictions based on the value of other fields in the same record.
The validation library has been updated to consider any conditional restrictions when resolving which restrictions need to be applied to a field.
Details
Dictionary
codeList
count
exists
range
regex
value
codeList
andregex
match rulesscript
restrictionsunique
restriction to be a property of a field, not part of restrictionsValidation
Scripts
Github Issue Tracking
This accomplishes the majority of tasks listed in #209 .
The missing tasks will be moved into separate tickets to be completed separately:
compare
restrictioncompare
conditional match rulearrayFieldCase
to modify the rules for matching values in a field with an array of values.