Skip to content
This repository was archived by the owner on Feb 17, 2023. It is now read-only.

Apply fixes from StyleCI #243

Merged
merged 1 commit into from
Jun 5, 2017
Merged

Apply fixes from StyleCI #243

merged 1 commit into from
Jun 5, 2017

Conversation

ovflowd
Copy link
Owner

@ovflowd ovflowd commented Jun 5, 2017

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

@ovflowd
Copy link
Owner Author

ovflowd commented Jun 5, 2017

Hi @Sant0ro!

Thanks for contributing on Chocolatey repository.

We're glad that you're using our software. I need to remember that this message was generated automatically.

We need clarify some things before we can review & approve your Pull Request:

  • Remember, only create a Pull Request to the development branch.
  • Explain your changes on your Pull Request
  • You need specify the purpose of the change
  • We also recommend to add screenshots of what was added.
  • We also recommend that you inform why those changes are useful.

Recommendations About your recently opened PR?

We really recommend using Lightshot to take your screenshot. It allows marks, annotations and more.

Also we recommend specify some Informations about your OS like.:

  • Operational System
  • Which Web Server are you using (like XAMPP)
  • Which version of Web Server Using (eg.: 1.7.3)
  • Which version of php & mysql & apache using. (Specify if is possible)
  • How much RAM does you have?

I created my PR and now?

You wait.

We have ful-jobs and a life, we will receive updates by e-mail and soon as possible update your PR by tagging it correctly, assigning to our team and obviously answering it.

We will review and if everything OK approve your PR with some time. Since we need analyze what's happening here.

Remember to test your changes before commiting it.

Remember also to undo any change on configuration files that you may have done.

Further information

@codecov
Copy link

codecov bot commented Jun 5, 2017

Codecov Report

Merging #243 into development will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #243      +/-   ##
==============================================
+ Coverage        26.37%   26.4%   +0.02%     
==============================================
  Files               69      69              
  Lines              963     962       -1     
==============================================
  Hits               254     254              
+ Misses             709     708       -1
Impacted Files Coverage Δ
app/Models/ChocolateyModel.php 66.66% <ø> (+16.66%) ⬆️
app/Helpers/User.php 56.75% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0998dd...bdf07f0. Read the comment docs.

@ovflowd ovflowd merged commit e182a7a into development Jun 5, 2017
@ovflowd ovflowd deleted the analysis-zR00xD branch June 5, 2017 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant