Skip to content
This repository was archived by the owner on Feb 17, 2023. It is now read-only.

CloudFlare IP Address Workarounds #264

Merged
merged 10 commits into from
Jul 11, 2017
Merged

CloudFlare IP Address Workarounds #264

merged 10 commits into from
Jul 11, 2017

Conversation

airilx96
Copy link
Contributor

Few fixes on users IP Address logging when server is using CloudFlare, IP Address of CloudFlare is logged instead of users real IP Address.

@airilx96 airilx96 changed the base branch from master to development July 11, 2017 17:45
@ovflowd
Copy link
Owner

ovflowd commented Jul 11, 2017

I think something is wrong in your commits. TravisCI Build it's saying that exists a bug.

@codecov
Copy link

codecov bot commented Jul 11, 2017

Codecov Report

Merging #264 into development will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             development     #264      +/-   ##
=================================================
- Coverage           26.4%   26.34%   -0.06%     
  Complexity           318      318              
=================================================
  Files                 69       70       +1     
  Lines                962      964       +2     
=================================================
  Hits                 254      254              
- Misses               708      710       +2
Impacted Files Coverage Δ Complexity Δ
app/Helpers/CloudFlare.php 0% <0%> (ø) 0% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6a5bd5...c31a19c. Read the comment docs.

@ovflowd
Copy link
Owner

ovflowd commented Jul 11, 2017

See what the TravisCI build log says. He says that cannot find the CloudFlareHelper.php

Check for case sensivity.

@airilx96
Copy link
Contributor Author

Hi, sorry for making too much changes. I've moved the fix files into /app/Helpers directory, as composer.json is having issues in detecting files in /app/ directory

@ovflowd
Copy link
Owner

ovflowd commented Jul 11, 2017

All checks passed.

Merging.

@ovflowd ovflowd merged commit 93963fe into ovflowd:development Jul 11, 2017
@ovflowd
Copy link
Owner

ovflowd commented Jul 11, 2017

Thanks for the contribution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants