fix: Fixed tasks using Batch or Subtask plugin getting stuck in the WAITING state #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrRebus
force-pushed
the
rtordjma/fix-tasks-stuck-waiting
branch
3 times, most recently
from
f205688 to
2fe9d72
Compare
…AITING state Signed-off-by: Ruben Tordjman <[email protected]>
DrRebus
force-pushed
the
rtordjma/fix-tasks-stuck-waiting
branch
from
2fe9d72 to
21607b6
Compare
DrRebus
requested review from
rbeuque74,
loopfz,
rclsilver and
wI2L
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug Fix
What is the current behavior? (You can also link to an open issue here)
Tasks using the Batch or Subtask plugin sometimes get stuck in the WAITING state because they miss the child task wake-up event.
When a child task finishes, it attempts to wake its parent up by running it. If the parent is already running at this time, this event is ignored and the child task terminates. However, the parent task may have run the step related to the child task before it finished and may think the child task is still running.
What is the new behavior (if this is a feature change)?
Instead of trying to run the parent, child tasks attempt to change the parent's
next_retrydate so they get rerun as soon as possible.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Nope.
Other information: