Skip to content

Commit

Permalink
client: Don't use LastTransactionID in MonitorArgs
Browse files Browse the repository at this point in the history
This is because we can't (yet) delay cache purge until after monitors
are re-established

Signed-off-by: Dave Tucker <[email protected]>
  • Loading branch information
dave-tucker committed Oct 12, 2021
1 parent 989834f commit ba06477
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -723,7 +723,12 @@ func (o *ovsdbClient) monitor(ctx context.Context, cookie MonitorCookie, reconne

var args []interface{}
if monitor.Method == ovsdb.ConditionalMonitorSinceRPC {
args = ovsdb.NewMonitorCondSinceArgs(dbName, cookie, requests, monitor.LastTransactionID)
// FIXME: We should pass the monitor.LastTransactionID here
// But that would require delaying clearing the cache until
// after the monitors have been re-established - the logic
// would also need to be different for monitor and monitor_cond
// as we must always clear the cache in that instance
args = ovsdb.NewMonitorCondSinceArgs(dbName, cookie, requests, emptyUUID)
} else {
args = ovsdb.NewMonitorArgs(dbName, cookie, requests)
}
Expand Down

0 comments on commit ba06477

Please sign in to comment.