Add Infrastructure params and Policy params rows in NS description#792
Open
AlexFalessi wants to merge 3 commits intoow2-proactive:NSDescriptionUpdatefrom
Open
Add Infrastructure params and Policy params rows in NS description#792AlexFalessi wants to merge 3 commits intoow2-proactive:NSDescriptionUpdatefrom
AlexFalessi wants to merge 3 commits intoow2-proactive:NSDescriptionUpdatefrom
Conversation
|
Can one of the admins verify this patch? |
oanaBiancaSchiopu
approved these changes
Aug 18, 2023
fviale
reviewed
Aug 18, 2023
| } | ||
|
|
||
| private String[] splitAndExtractNameAndParamsFromDescription(String input) { | ||
| String[] elements = input.split(","); |
Member
There was a problem hiding this comment.
not ideal, this suppose you have a comma after the infrastructure or policy name.
you should extract the first word of the input instead.
String[] elements = input.split("[,\s]+");
fviale
reviewed
Aug 22, 2023
| } | ||
|
|
||
| private String[] splitAndExtractNameAndParamsFromDescription(String input) { | ||
| String[] elements = input.split("[,\\s]+"); |
Member
There was a problem hiding this comment.
you can make this code much simpler
return input.trim().split("[,\\s]+", 2);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.