Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ehnance testing adding owl-top and owl-zoo #31

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,16 +54,16 @@ jobs:
- name: Build project
run: opam exec -- dune build -p eigen

- name: Install openblas on windows
- name: Install openblas on windows (for testing owl)
if: ${{ runner.os == 'Windows' }}
run: |
echo pwd
git clone https://github.com/xianyi/OpenBLAS.git || true
cd OpenBLAS
make CC=x86_64-w64-mingw32-gcc FC=x86_64-w64-mingw32-gfortran TARGET=HASWELL
make CC=x86_64-w64-mingw32-gcc FC=x86_64-w64-mingw32-gfortran TARGET=HASWELL PREFIX=/usr/x86_64-w64-mingw32/sys-root/mingw install
make CC=x86_64-w64-mingw32-gcc FC=x86_64-w64-mingw32-gfortran
make CC=x86_64-w64-mingw32-gcc FC=x86_64-w64-mingw32-gfortran PREFIX=/usr/x86_64-w64-mingw32/sys-root/mingw install

- name: Build and test owl
run: |
opam depext owl
opam install -t owl
opam depext owl owl-top owl-zoo
opam install -t owl owl-top owl-zoo
8 changes: 8 additions & 0 deletions CHANGES
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# 0.4.0 (12-11-2020)

* Fix bug in linking cmxs files ([#27](https://github.com/owlbarn/eigen/issues/27) @nojb @nilsbecker @dbuenzli)

# 0.3.0 (22-10-2020)

* Release 0.3.0, windows compatibility (thanks to @kkirstein)

3 changes: 2 additions & 1 deletion dune-project
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
(lang dune 2.0)
(lang dune 2.8)
(name eigen)
(use_standard_c_and_cxx_flags true)
2 changes: 1 addition & 1 deletion eigen.opam
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ build: [
depends: [
"ocaml" {>= "4.02"}
"ctypes" {>= "0.14.0"}
"dune" {>= "2.0.0"}
"dune" {>= "2.8.0"}
]
synopsis: "Owl's OCaml interface to Eigen3 C++ library"
description:
Expand Down
4 changes: 2 additions & 2 deletions eigen/dune
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ let () = Printf.ksprintf Jbuild_plugin.V1.send {|
(public_name eigen)
(libraries ctypes)
(modules :standard ffi_eigen_generated)
(foreign_archives ../eigen_cpp/eigen_cpp_stubs)
(foreign_archives ../eigen_cpp/eigen_cpp)
(foreign_stubs
(language c)
(names eigen_utils_stubs ffi_eigen_generated_stub)
(include_dirs ../eigen_cpp/lib)
(flags :standard %s)
(flags :standard -lstdc++ -leigen_cpp %s)
)
)
|} eigen_flags
6 changes: 3 additions & 3 deletions eigen_cpp/dune
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@

let optflags =
match Sys.getenv "EIGENCPP_OPTFLAGS" with
| s ->
s
| s -> s
| exception Not_found ->
"-Ofast -march=native -funroll-loops -ffast-math"

Expand All @@ -17,7 +16,7 @@ let () = Printf.ksprintf Jbuild_plugin.V1.send {|
(include_subdirs unqualified)

(foreign_library
(archive_name eigen_cpp_stubs)
(archive_name eigen_cpp)
(language cxx)
(names eigen_tensor eigen_dsmat eigen_spmat)
(include_dirs lib lib/unsupported)
Expand All @@ -29,6 +28,7 @@ let () = Printf.ksprintf Jbuild_plugin.V1.send {|
-O3
-std=c++11
-lstdc++
-fno-threadsafe-statics
%s
%s
)
Expand Down
1 change: 0 additions & 1 deletion eigen_cpp/eigen_cpp.ml

This file was deleted.