Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows installation doc #585

Merged
merged 6 commits into from
Jul 5, 2021
Merged

Windows installation doc #585

merged 6 commits into from
Jul 5, 2021

Conversation

kkirstein
Copy link

I have updated the installation docs for PLplot on Windows. Unfortunately, it is quite a hack, as cross-compiling PLplot seems not to work for the Cygwin/Mingw combination.
Anyway, if I remember correctly, last time there was a suggestions to merge these instructions into the main README.
Personally, I would prefer to keep it separate, but of course, that's up to the maintainers. Alternatively, these instructions might also be included in the Owl book.
Please feel free to give feedback, if something is unclear.

@jzstark jzstark self-assigned this May 12, 2021
@kkirstein
Copy link
Author

In the meantime I got some valuable input from the PLplot developers, on how to fix the build issues. Please find the updated instructions now.

@ryanrhymes ryanrhymes requested review from ryanrhymes and mseri May 13, 2021 07:22
Copy link
Member

@mseri mseri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Thanks a lot

@kkirstein
Copy link
Author

In the meantime, the issue with pkg-confighas been fixed (fdopen/opam-repository-mingw#96), but I will leave the workaround in, as not everybody might update their OCaml/Windows toolchain so regularly.

@mseri
Copy link
Member

mseri commented Jun 29, 2021

What is preventing this PR to be merged? @jzstark @ryanrhymes

@jzstark
Copy link
Collaborator

jzstark commented Jul 5, 2021

So sorry for the late reply! Me and Liang have been really busy with other projects recently. This PR looks great and I'll soon merge it.

@jzstark jzstark merged commit 11aa874 into owlbarn:master Jul 5, 2021
@kkirstein kkirstein deleted the doc branch July 6, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants