Open
Conversation
ilestis
requested changes
Mar 4, 2026
Member
ilestis
left a comment
ilestis
left a comment
There was a problem hiding this comment.
Don't keep the column name is_something if it's not a pure boolean. Use enums.
database/migrations/2026_03_03_225300_update_characters_is_dead_to_tinyinteger.php
Show resolved
Hide resolved
database/migrations/2026_03_04_044125_update_quests_is_completed_to_tinyinteger.php
Show resolved
Hide resolved
ilestis
requested changes
Mar 6, 2026
Member
ilestis
left a comment
ilestis
left a comment
There was a problem hiding this comment.
Please follow conventions established in Kanka. If an enum is an int, the field should be called status_id. Bulk updating also seems like it wouldn't work.
|
|
||
| protected array $booleans = [ | ||
| 'is_dead', | ||
| 'status', |
app/Datagrids/Bulks/QuestBulk.php
Outdated
|
|
||
| protected array $booleans = [ | ||
| 'is_completed', | ||
| 'status', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.